Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1355758
| From | Vladimir Davydov <vdavydov@virtuozzo.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] mm: memcontrol: reclaim and OOM kill when shrinking memory.max below usage |
| Date | 2016-03-11 10:30 +0100 |
| Message-ID | <rbryp-3Zo-1@gated-at.bofh.it> (permalink) |
| References | <rbfQC-3PQ-3@gated-at.bofh.it> <rbqsF-3iZ-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Mar 11, 2016 at 09:18:25AM +0100, Michal Hocko wrote:
> On Thu 10-03-16 15:50:14, Johannes Weiner wrote:
...
> > @@ -5037,9 +5040,36 @@ static ssize_t memory_max_write(struct kernfs_open_file *of,
> > if (err)
> > return err;
> >
> > - err = mem_cgroup_resize_limit(memcg, max);
> > - if (err)
> > - return err;
> > + xchg(&memcg->memory.limit, max);
> > +
> > + for (;;) {
> > + unsigned long nr_pages = page_counter_read(&memcg->memory);
> > +
> > + if (nr_pages <= max)
> > + break;
> > +
> > + if (signal_pending(current)) {
>
> Didn't you want fatal_signal_pending here? At least the changelog
> suggests that.
I suppose the user might want to interrupt the write by hitting CTRL-C.
Come to think of it, shouldn't we restore the old limit and return EBUSY
if we failed to reclaim enough memory?
>
> > + err = -EINTR;
> > + break;
> > + }
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] mm: memcontrol: reclaim and OOM kill when shrinking memory.max below usage Johannes Weiner <hannes@cmpxchg.org> - 2016-03-10 22:00 +0100
Re: [PATCH] mm: memcontrol: reclaim and OOM kill when shrinking memory.max below usage Michal Hocko <mhocko@kernel.org> - 2016-03-11 09:20 +0100
Re: [PATCH] mm: memcontrol: reclaim and OOM kill when shrinking memory.max below usage Vladimir Davydov <vdavydov@virtuozzo.com> - 2016-03-11 10:30 +0100
Re: [PATCH] mm: memcontrol: reclaim and OOM kill when shrinking memory.max below usage Johannes Weiner <hannes@cmpxchg.org> - 2016-03-16 06:20 +0100
Re: [PATCH] mm: memcontrol: reclaim and OOM kill when shrinking memory.max below usage Michal Hocko <mhocko@kernel.org> - 2016-03-16 09:50 +0100
Re: [PATCH] mm: memcontrol: reclaim and OOM kill when shrinking memory.max below usage Vladimir Davydov <vdavydov@virtuozzo.com> - 2016-03-16 16:50 +0100
Re: [PATCH] mm: memcontrol: reclaim and OOM kill when shrinking memory.max below usage Johannes Weiner <hannes@cmpxchg.org> - 2016-03-16 21:20 +0100
Re: [PATCH] mm: memcontrol: reclaim and OOM kill when shrinking memory.max below usage Vladimir Davydov <vdavydov@virtuozzo.com> - 2016-03-17 09:40 +0100
csiph-web