[patch] mfd: lp8788-irq: uninitialized variable in irq handler

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	[patch] mfd: lp8788-irq: uninitialized variable in irq handler
Date	2016-03-11 09:20 +0100
Message-ID	<rbqsF-3iZ-5@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Instead to being true/false, the "handled" is true/uninitialized.
Presumably this doesn't cause that many problems in real life because
normally we handle the IRQ.

Fixes: eea6b7cc53aa ('mfd: Add lp8788 mfd driver')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/mfd/lp8788-irq.c b/drivers/mfd/lp8788-irq.c
index c7a9825..792d51b 100644
--- a/drivers/mfd/lp8788-irq.c
+++ b/drivers/mfd/lp8788-irq.c
@@ -112,7 +112,7 @@ static irqreturn_t lp8788_irq_handler(int irq, void *ptr)
 	struct lp8788_irq_data *irqd = ptr;
 	struct lp8788 *lp = irqd->lp;
 	u8 status[NUM_REGS], addr, mask;
-	bool handled;
+	bool handled = false;
 	int i;
 
 	if (lp8788_read_multi_bytes(lp, LP8788_INT_1, status, NUM_REGS))

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[patch] mfd: lp8788-irq: uninitialized variable in irq handler Dan Carpenter <dan.carpenter@oracle.com> - 2016-03-11 09:20 +0100
  Re: [patch] mfd: lp8788-irq: uninitialized variable in irq handler "Kim, Milo" <milo.kim@ti.com> - 2016-03-14 00:20 +0100

csiph-web