Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1355659

Re: [PATCH] android: lmk: add swap pte pmd in tasksize

From yalin wang <yalin.wang2010@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH] android: lmk: add swap pte pmd in tasksize
Date 2016-03-11 08:40 +0100
Message-ID <rbpPZ-2Oc-39@gated-at.bofh.it> (permalink)
References <rbpGi-2IW-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


> On Mar 11, 2016, at 15:23, Lu Bing <albert.lubing@hisilicon.com> wrote:
> 
> From: l00215322 <albert.lubing@hisilicon.com>
> 
> Many android devices have zram,so we should add "MM_SWAPENTS" in tasksize.
> Refer oom_kill.c,we add pte&pmd also.
> 
> Reviewed-by: Chen Feng <puck.chen@hisilicon.com>
> Reviewed-by: Fu Jun <oliver.fu@hisilicon.com>
> Reviewed-by: Xu YiPing <xuyiping@hisilicon.com>
> Reviewed-by: Yu DongBin <yudongbin@hisilicon.com>
> Signed-off-by: Lu Bing <albert.lubing@hisilicon.com>
> ---
> drivers/staging/android/lowmemorykiller.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/android/lowmemorykiller.c b/drivers/staging/android/lowmemorykiller.c
> index 8b5a4a8..0817d3b 100644
> --- a/drivers/staging/android/lowmemorykiller.c
> +++ b/drivers/staging/android/lowmemorykiller.c
> @@ -139,7 +139,9 @@ static unsigned long lowmem_scan(struct shrinker *s, struct shrink_control *sc)
> 			task_unlock(p);
> 			continue;
> 		}
> -		tasksize = get_mm_rss(p->mm);
> +		tasksize = get_mm_rss(p->mm) +
> +			get_mm_counter(p->mm, MM_SWAPENTS) +
> +			atomic_long_read(&p->mm->nr_ptes) + mm_nr_pmds(p->mm);
why not introduce a mm_nr_ptes()  help function here ?
more clear to see .

> 		task_unlock(p);
> 		if (tasksize <= 0)
> 			continue;
> -- 
> 1.8.3.2
> 

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] android: lmk: add swap pte pmd in tasksize Lu Bing <albert.lubing@hisilicon.com> - 2016-03-11 08:30 +0100
  Re: [PATCH] android: lmk: add swap pte pmd in tasksize yalin wang <yalin.wang2010@gmail.com> - 2016-03-11 08:40 +0100
    Re: [PATCH] android: lmk: add swap pte pmd in tasksize Chen Feng <puck.chen@hisilicon.com> - 2016-03-11 10:10 +0100
      Re: [PATCH] android: lmk: add swap pte pmd in tasksize Greg KH <gregkh@linuxfoundation.org> - 2016-03-11 18:20 +0100
        Re: [PATCH] android: lmk: add swap pte pmd in tasksize Chen Feng <puck.chen@hisilicon.com> - 2016-03-14 02:30 +0100

csiph-web