Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1355590

Re: [PATCH v1 2/3] mailbox: rockchip: Add Rockchip mailbox driver

From Jassi Brar <jassisinghbrar@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH v1 2/3] mailbox: rockchip: Add Rockchip mailbox driver
Date 2016-03-11 04:50 +0100
Message-ID <rbmfn-bV-3@gated-at.bofh.it> (permalink)
References <qo71o-2ou-19@gated-at.bofh.it> <qo71o-2ou-27@gated-at.bofh.it> <ra8oa-6zK-21@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, Mar 8, 2016 at 1:48 AM, Heiko Stübner <heiko@sntech.de> wrote:
> Hi Jassi,
>
> Am Dienstag, 27. Oktober 2015, 15:31:45 schrieb Caesar Wang:
>> This driver is found on RK3368 SoCs.
>>
>> The Mailbox module is a simple APB peripheral that allows both
>> the Cortex-A53 MCU system to communicate by writing operation to
>> generate interrupt.
>> The registers are accessible by both CPU via APB interface.
>>
>> The Mailbox has the following main features:
>>
>> 1) Support dual-core system: Cortex-A53 and MCU.
>> 2) Support APB interface.
>> 3) Support four mailbox elements, each element includes one data word,
>>    one command word register and one flag bit that can represent
>>    one interrupt.
>> 4) Four interrupts to Cortex-A53.
>> 5) Four interrupts to MCU.
>> 6) Provide 32 lock registers for software to use to indicate whether
>>    mailbox is occupied.
>>
>> Signed-off-by: Caesar Wang <wxt@rock-chips.com>
>
> it seems this patch has fallen through the cracks. Could you take a look if it
> needs anything else?
>
The 0Day kbuild test robot had reported an error in the 3rd patch. I
was expecting another revision. Though that patch shouldn't go via
mailbox tree, so I am picking up the first two patches with a minor
change that is removing the unused variable 'buf_base'.

Thanks.

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

Re: [PATCH v1 2/3] mailbox: rockchip: Add Rockchip mailbox driver Heiko Stübner <heiko@sntech.de> - 2016-03-07 19:50 +0100
  Re: [PATCH v1 2/3] mailbox: rockchip: Add Rockchip mailbox driver Jassi Brar <jassisinghbrar@gmail.com> - 2016-03-11 04:50 +0100

csiph-web