[PATCH 1/8] f2fs: check inline flag ahead for f2fs_write_inline_data

From	Shawn Lin <shawn.lin@rock-chips.com>
Newsgroups	linux.kernel
Subject	[PATCH 1/8] f2fs: check inline flag ahead for f2fs_write_inline_data
Date	2016-03-11 04:40 +0100
Message-ID	<rbm5I-8y-17@gated-at.bofh.it> (permalink)
References	<rbm5I-8y-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

No matter inline data flag is set or not, current code is
going to new a dnode. But actually we can avoid it by puting
the check of inline data flag in advance to save this cpu cycle.

Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>

---

 fs/f2fs/inline.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/fs/f2fs/inline.c b/fs/f2fs/inline.c
index 358214e..0926eab 100644
--- a/fs/f2fs/inline.c
+++ b/fs/f2fs/inline.c
@@ -195,16 +195,14 @@ int f2fs_write_inline_data(struct inode *inode, struct page *page)
 	struct dnode_of_data dn;
 	int err;
 
+	if (!f2fs_has_inline_data(inode))
+		return -EAGAIN;
+
 	set_new_dnode(&dn, inode, NULL, NULL, 0);
 	err = get_dnode_of_data(&dn, 0, LOOKUP_NODE);
 	if (err)
 		return err;
 
-	if (!f2fs_has_inline_data(inode)) {
-		f2fs_put_dnode(&dn);
-		return -EAGAIN;
-	}
-
 	f2fs_bug_on(F2FS_I_SB(inode), page->index);
 
 	f2fs_wait_on_page_writeback(dn.inode_page, NODE, true);
-- 
2.3.7

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 1/8] f2fs: check inline flag ahead for f2fs_write_inline_data Shawn Lin <shawn.lin@rock-chips.com> - 2016-03-11 04:40 +0100

csiph-web