Re: [RESPIN 1/6] dt-bindings: EXYNOS: Add exynos-srom device tree binding

From	"pankaj.dubey" <pankaj.dubey@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [RESPIN 1/6] dt-bindings: EXYNOS: Add exynos-srom device tree binding
Date	2016-03-11 03:40 +0100
Message-ID	<rbl9D-7NC-11@gated-at.bofh.it> (permalink)
References	<r5ZCO-15Z-9@gated-at.bofh.it> <r5ZCQ-15Z-39@gated-at.bofh.it> <r8je2-2XE-1@gated-at.bofh.it> <r9dJf-21E-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On Saturday 05 March 2016 11:48 AM, pankaj.dubey wrote:
> Hi
> 
> On Wednesday 02 March 2016 11:23 PM, Rob Herring wrote:
>> On Thu, Feb 25, 2016 at 02:03:37PM +0530, Pankaj Dubey wrote:
>>> This patch adds exynos-srom binding information for SROM Controller
>>> driver on Exynos SoCs.
>>>
>>> CC: Rob Herring <robh+dt@kernel.org>
>>> CC: Mark Rutland <mark.rutland@arm.com>
>>> CC: Ian Campbell <ijc+devicetree@hellion.org.uk>
>>> CC: devicetree@vger.kernel.org
>>> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
>>> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>>> Signed-off-by: Kukjin Kim <kgene@kernel.org>
>>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>>> ---
>>>  .../devicetree/bindings/memory-controllers/exynos-srom.txt   | 12 ++++++++++++
>>>  1 file changed, 12 insertions(+)
>>>  create mode 100644 Documentation/devicetree/bindings/memory-controllers/exynos-srom.txt
>>>
>>> diff --git a/Documentation/devicetree/bindings/memory-controllers/exynos-srom.txt b/Documentation/devicetree/bindings/memory-controllers/exynos-srom.txt
>>> new file mode 100644
>>> index 0000000..33886d5
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/memory-controllers/exynos-srom.txt
>>> @@ -0,0 +1,12 @@
>>> +SAMSUNG Exynos SoCs SROM Controller driver.
>>> +
>>> +Required properties:
>>> +- compatible : Should contain "samsung,exynos-srom".
>>
>> There should be SoC specific compatible strings in addition to this.
>>
> 
> I do not understood need of additional SoC specific compatible here. As
> of now all SoCs having SROM can work with exynos specific common
> compatible. Do you see any issues if we do not have SoC specific
> compatible here.
> 

Gentle ping.

Thanks,
Pankaj Dubey

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RESPIN 1/6] dt-bindings: EXYNOS: Add exynos-srom device tree  binding "pankaj.dubey" <pankaj.dubey@samsung.com> - 2016-03-05 07:20 +0100
  Re: [RESPIN 1/6] dt-bindings: EXYNOS: Add exynos-srom device tree  binding "pankaj.dubey" <pankaj.dubey@samsung.com> - 2016-03-11 03:40 +0100

csiph-web