Re: [patch] sbp-target: checking for NULL instead of IS_ERR

From	Chris Boot <bootc@bootc.net>
Newsgroups	linux.kernel
Subject	Re: [patch] sbp-target: checking for NULL instead of IS_ERR
Date	2016-03-10 23:00 +0100
Message-ID	<rbgMF-4AF-3@gated-at.bofh.it> (permalink)
References	<r8bTe-6bA-37@gated-at.bofh.it> <r9eYF-2Pv-3@gated-at.bofh.it> <r9ge7-3AS-19@gated-at.bofh.it> <r9gQO-47B-9@gated-at.bofh.it> <rbfQC-3PQ-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 10/03/16 20:56, Chris Boot wrote:
> On 05/03/16 09:33, Nicholas A. Bellinger wrote:
>> On Sat, 2016-03-05 at 08:45 +0000, Chris Boot wrote:
>>> Are these in linux-next or another branch somewhere I can easily clone
>>> them from?
>>
>> The patch series is in target-pending/for-next.
> 
> Hi Nic,
> 
> I've just managed to resurrect a test rig for this (the hardware I had
> for it has stopped being usable, yay!), and my initial testing shows the
> updated code panics on the first submitted IO.

So this isn't the first IO, it's exactly the 2nd IO. I'm hitting
BUG_ON(se_cmd->se_tfo || se_cmd->se_sess) in target_submit_cmd_map_sgls().

I'm assuming the se_cmd is being reused due to percpu ida allocator, and
the code must be missing something to clean up the se_cmd sufficiently
once we're done with it.

At this point I'm out of my depth going through the target core, so I'd
appreciate some pointers to get any further!

Thanks,
Chris

-- 
Chris Boot
bootc@bootc.net

Thread

Re: [patch] sbp-target: checking for NULL instead of IS_ERR "Nicholas A. Bellinger" <nab@linux-iscsi.org> - 2016-03-05 08:40 +0100
  Re: [patch] sbp-target: checking for NULL instead of IS_ERR Chris Boot <bootc@bootc.net> - 2016-03-05 10:00 +0100
    Re: [patch] sbp-target: checking for NULL instead of IS_ERR "Nicholas A. Bellinger" <nab@linux-iscsi.org> - 2016-03-05 10:40 +0100
      Re: [patch] sbp-target: checking for NULL instead of IS_ERR Chris Boot <bootc@bootc.net> - 2016-03-10 22:00 +0100
        Re: [patch] sbp-target: checking for NULL instead of IS_ERR Chris Boot <bootc@bootc.net> - 2016-03-10 23:00 +0100
          Re: [patch] sbp-target: checking for NULL instead of IS_ERR Chris Boot <bootc@bootc.net> - 2016-03-11 00:00 +0100
            Re: [patch] sbp-target: checking for NULL instead of IS_ERR "Nicholas A. Bellinger" <nab@linux-iscsi.org> - 2016-03-11 05:40 +0100

csiph-web