Re: [PATCH] ld-version: Fix awk regex compile failure

From	James Hogan <james.hogan@imgtec.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ld-version: Fix awk regex compile failure
Date	2016-03-10 22:00 +0100
Message-ID	<rbfQD-3PQ-19@gated-at.bofh.it> (permalink)
References	<rasZA-3on-3@gated-at.bofh.it> <rbd2r-1Zy-41@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Thu, Mar 10, 2016 at 11:19:57PM +0530, Sudip Mukherjee wrote:
> On Tuesday 08 March 2016 10:17 PM, James Hogan wrote:
> > The ld-version.sh script fails on some versions of awk with the
> > following error, resulting in build failures for MIPS:
> >
> > awk: scripts/ld-version.sh: line 4: regular expression compile failed (missing '(')
> >
> > This is due to the regular expression ".*)", meant to strip off the
> > beginning of the ld version string up to the close bracket, however
> > brackets have a meaning in regular expressions, so lets escape it so
> > that awk doesn't expect a corresponding open bracket.
> >
> > Fixes: ccbef1674a15 ("Kbuild, lto: add ld-version and ld-ifversion ...")
> > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > Signed-off-by: James Hogan <james.hogan@imgtec.com>
> 
> This error was only coming in my gitlab builds but was not showing in 
> the build of travis-ci. Maybe it depends on the version of awk also.
> Build log at: https://gitlab.com/sudipm/linux-next/builds/839573
> 
> Tested-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>

Great, that looks pretty conclusive. Thanks for testing Sudip and
Michael.

Ralf: is it too late to get this into v4.5 via MIPS tree?

Cheers
James

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ld-version: Fix awk regex compile failure James Hogan <james.hogan@imgtec.com> - 2016-03-08 17:50 +0100
  Re: [PATCH] ld-version: Fix awk regex compile failure "Michael S. Tsirkin" <mst@redhat.com> - 2016-03-08 18:00 +0100
  Re: [PATCH] ld-version: Fix awk regex compile failure Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-03-10 19:00 +0100
    Re: [PATCH] ld-version: Fix awk regex compile failure James Hogan <james.hogan@imgtec.com> - 2016-03-10 22:00 +0100

csiph-web