Re: [PATCH] kcm: mark helper functions inline

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] kcm: mark helper functions inline
Date	2016-03-10 20:50 +0100
Message-ID	<rbeKS-37I-5@gated-at.bofh.it> (permalink)
References	<rbdF8-2tR-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Arnd Bergmann <arnd@arndb.de>
Date: Thu, 10 Mar 2016 19:31:12 +0100

> The stub helper functions for the newly added kcm_proc_init/exit interfaces
> are defined as 'static' in a header file, which leads to build warnings for
> each file that includes them without calling them:
> 
> include/net/kcm.h:183:12: error: 'kcm_proc_init' defined but not used [-Werror=unused-function]
> include/net/kcm.h:184:13: error: 'kcm_proc_exit' defined but not used [-Werror=unused-function]
> 
> This marks the two functions as 'static inline' instead, which avoids the
> warnings and is obviously what was meant here.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: cd6e111bf5be ("kcm: Add statistics and proc interfaces")

Applied, thanks Arnd.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] kcm: mark helper functions inline Arnd Bergmann <arnd@arndb.de> - 2016-03-10 19:40 +0100
  Re: [PATCH] kcm: mark helper functions inline David Miller <davem@davemloft.net> - 2016-03-10 20:50 +0100

csiph-web