Re: [PATCH] tools lib traceevent: Add '~' operation within arg_num_eval()

From	David Ahern <dsahern@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] tools lib traceevent: Add '~' operation within arg_num_eval()
Date	2016-03-10 17:20 +0100
Message-ID	<rbbtD-16X-7@gated-at.bofh.it> (permalink)
References	(2 earlier) <r6yqT-W4-29@gated-at.bofh.it> <r6yqU-W4-39@gated-at.bofh.it> <r6yKe-1lH-3@gated-at.bofh.it> <r6zPY-26L-13@gated-at.bofh.it> <r6AiZ-2oo-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 2/26/16 4:45 PM, David Ahern wrote:
> On 2/26/16 4:13 PM, Steven Rostedt wrote:
>> When evaluating values for print flags, if the value included a '~'
>> operator, the parsing would fail. This broke kmalloc's parsing of:
>>
>> __print_flags(REC->gfp_flags, "|", {(unsigned
>> long)((((((( gfp_t)(0x400000u|0x2000000u)) | (( gfp_t)0x40u) |
>> (( gfp_t)0x80u) | (( gfp_t)0x20000u)) | (( gfp_t)0x02u)) |
>> (( gfp_t)0x08u)) | (( gfp_t)0x4000u) | (( gfp_t)0x10000u) |
>> (( gfp_t)0x1000u) | (( gfp_t)0x200u)) & ~(( gfp_t)0x2000000u))
>>                                          ^
>>                                          |
>>                                        here
>>
>> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
>> ---
>
> I've been meaning to chase this down for a few weeks. Worked for me.
>
> Tested-by: David Ahern <dsahern@gmail.com>

Arnaldo: have not seen this one hit your tree. Did it fall through the 
cracks?

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] tools lib traceevent: Add '~' operation within  arg_num_eval() David Ahern <dsahern@gmail.com> - 2016-03-10 17:20 +0100
  Re: [PATCH] tools lib traceevent: Add '~' operation within  arg_num_eval() Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-03-10 20:30 +0100

csiph-web