Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1356498
| From | Gregory CLEMENT <gregory.clement@free-electrons.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH net v2 4/4] net: mvneta: replace magic numbers by existing macros |
| Date | 2016-03-12 18:50 +0100 |
| Message-ID | <rbVPR-1dq-35@gated-at.bofh.it> (permalink) |
| References | <rbVPQ-1dq-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Dmitri Epshtein <dima@marvell.com> Some literal values are actually already defined by macros, so let's use them. [gregory.clement@free-electrons.com: split intial commit in two individual changes] Signed-off-by: Dmitri Epshtein <dima@marvell.com> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com> --- drivers/net/ethernet/marvell/mvneta.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c index 58ad36876e8b..225d933259c0 100644 --- a/drivers/net/ethernet/marvell/mvneta.c +++ b/drivers/net/ethernet/marvell/mvneta.c @@ -880,7 +880,7 @@ static void mvneta_port_down(struct mvneta_port *pp) mdelay(1); val = mvreg_read(pp, MVNETA_RXQ_CMD); - } while (val & 0xff); + } while (val & MVNETA_RXQ_ENABLE_MASK); /* Stop Tx port activity. Check port Tx activity. Issue stop * command for active channels only @@ -905,7 +905,7 @@ static void mvneta_port_down(struct mvneta_port *pp) /* Check TX Command reg that all Txqs are stopped */ val = mvreg_read(pp, MVNETA_TXQ_CMD); - } while (val & 0xff); + } while (val & MVNETA_TXQ_ENABLE_MASK); /* Double check to verify that TX FIFO is empty */ count = 0; -- 2.5.0
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH net v2 0/4] Few mvneta fixes Gregory CLEMENT <gregory.clement@free-electrons.com> - 2016-03-12 18:50 +0100 [PATCH net v2 4/4] net: mvneta: replace magic numbers by existing macros Gregory CLEMENT <gregory.clement@free-electrons.com> - 2016-03-12 18:50 +0100 Re: [PATCH net v2 0/4] Few mvneta fixes David Miller <davem@davemloft.net> - 2016-03-14 20:50 +0100
csiph-web