Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1356479

Re: [PATCH 3/7] clk: rockchip: release io resource when rk3036_clk_init failed

Show all headers | View raw

Hi Shawn,

Am Sonntag, 13. März 2016, 00:25:25 schrieb Shawn Lin:
> We should call iounmap to relase reg_base since it's not going
> to be used any more.
> 
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>

I see that change for rk3036, rk3188(+rk3066) and rk3368.
But it looks like rk3228 and rk3288 should also get that, or am I just 
overlooking something?

Also, I think we can fold these changes into one patch, as it's the completely 
same addition for all clock-drivers.


Heiko

> ---
> 
>  drivers/clk/rockchip/clk-rk3036.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/rockchip/clk-rk3036.c
> b/drivers/clk/rockchip/clk-rk3036.c index 8c683cc..284c36f 100644
> --- a/drivers/clk/rockchip/clk-rk3036.c
> +++ b/drivers/clk/rockchip/clk-rk3036.c
> @@ -453,6 +453,7 @@ static void __init rk3036_clk_init(struct device_node
> *np) ctx = rockchip_clk_init(np, reg_base, CLK_NR_CLKS);
>  	if (IS_ERR(ctx)) {
>  		pr_err("%s: rockchip clk init failed\n", __func__);
> +		iounmap(reg_base);
>  		return;
>  	}

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/7] Some trivial patches for rockchip clk stuff Shawn Lin <shawn.lin@rock-chips.com> - 2016-03-12 17:40 +0100
  [PATCH 4/7] clk: rockchip: release io resource when rk3188_common_clk_init failed Shawn Lin <shawn.lin@rock-chips.com> - 2016-03-12 17:40 +0100
  [PATCH 5/7] clk: rockchip: release io resource when rk3368_clk_init failed Shawn Lin <shawn.lin@rock-chips.com> - 2016-03-12 17:40 +0100
  [PATCH 3/7] clk: rockchip: release io resource when rk3036_clk_init failed Shawn Lin <shawn.lin@rock-chips.com> - 2016-03-12 17:40 +0100
    Re: [PATCH 3/7] clk: rockchip: release io resource when rk3036_clk_init failed Heiko Stübner <heiko@sntech.de> - 2016-03-12 17:50 +0100
      Re: [PATCH 3/7] clk: rockchip: release io resource when  rk3036_clk_init failed Shawn Lin <shawn.lin@kernel-upstream.org> - 2016-03-13 03:00 +0100
  [PATCH 1/7] clk: rockchip: remove mux_core_reg from rockchip_cpuclk_reg_data Shawn Lin <shawn.lin@rock-chips.com> - 2016-03-12 17:40 +0100
    Re: [PATCH 1/7] clk: rockchip: remove mux_core_reg from rockchip_cpuclk_reg_data Heiko Stuebner <heiko@sntech.de> - 2016-03-14 01:20 +0100
  [PATCH 7/7] clk: rockchip: fix a typo for rockchip_rk3399_pll_set_params Shawn Lin <shawn.lin@rock-chips.com> - 2016-03-12 17:40 +0100
    Re: [PATCH 7/7] clk: rockchip: fix a typo for rockchip_rk3399_pll_set_params Heiko Stübner <heiko@sntech.de> - 2016-03-12 17:50 +0100
  [PATCH 2/7] clk: rockchip: fix warning reported by kernel-doc Shawn Lin <shawn.lin@rock-chips.com> - 2016-03-12 17:40 +0100
    Re: [PATCH 2/7] clk: rockchip: fix warning reported by kernel-doc Heiko Stuebner <heiko@sntech.de> - 2016-03-14 01:30 +0100

csiph-web