[PATCH] debugfs: fix double unlock in open_proxy_open()

From	Nicolai Stange <nicstange@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH] debugfs: fix double unlock in open_proxy_open()
Date	2016-03-12 16:10 +0100
Message-ID	<rbTkZ-7Va-1@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

In case an open is racing with a debugfs file removal, the corresponding
error path in open_proxy_open() releases its SRCU read side critical
section twice, i.e. it does a double unlock.

Fix that by purging the extra unlock operation.

Signed-off-by: Nicolai Stange <nicstange@gmail.com>
---
 fs/debugfs/file.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/debugfs/file.c b/fs/debugfs/file.c
index 6a4b667..9c1c9a0 100644
--- a/fs/debugfs/file.c
+++ b/fs/debugfs/file.c
@@ -108,7 +108,6 @@ static int open_proxy_open(struct inode *inode, struct file *filp)
 
 	r = debugfs_use_file_start(dentry, &srcu_idx);
 	if (r) {
-		debugfs_use_file_finish(srcu_idx);
 		r = -ENOENT;
 		goto out;
 	}
-- 
2.7.2

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] debugfs: fix double unlock in open_proxy_open() Nicolai Stange <nicstange@gmail.com> - 2016-03-12 16:10 +0100
  Re: [PATCH] debugfs: fix double unlock in open_proxy_open() Nicolai Stange <nicstange@gmail.com> - 2016-03-12 16:30 +0100
  Re: [PATCH] debugfs: fix double unlock in open_proxy_open() Nicolai Stange <nicstange@gmail.com> - 2016-03-12 16:30 +0100

csiph-web