Re: [PATCH] iio: adc: imx25-gcq: fix do_div

From	Jonathan Cameron <jic23@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] iio: adc: imx25-gcq: fix do_div
Date	2016-03-12 12:10 +0100
Message-ID	<rbPAJ-51S-3@gated-at.bofh.it> (permalink)
References	<r8B1h-7eH-25@gated-at.bofh.it> <r9pr4-1LI-5@gated-at.bofh.it> <r9ZkR-QT-1@gated-at.bofh.it> <ra1d0-24s-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 07/03/16 11:06, Sudip Mukherjee wrote:
> On Mon, Mar 07, 2016 at 10:01:34AM +0100, Markus Pargmann wrote:
>> Hi,
>>
>> On Saturday 05 March 2016 18:43:11 Jonathan Cameron wrote:
>>> On 03/03/16 12:51, Sudip Mukherjee wrote:
>>>> We are getting build failure with tilepro allmodconfig with the error:
>>>>
>>>> drivers/iio/adc/fsl-imx25-gcq.c:236:4: note: in expansion of macro 'do_div'
>>>> do_div(priv->channel_vref_mv[reg], 1000);
>>>>     ^
>>>>
>>>> include/asm-generic/div64.h:198:17: note: expected 'uint64_t *
>>>> 	{aka long long unsigned int *}' but argument is of type 'u32 *
>>>> 	{aka unsigned int *}'
>>>>
>>>> Create a temporary variable of type u64 and use that in do_div.
>>>>
>>>> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
>>> Markus, can you take a quick look at this. 
>>
>> Thanks. I think this was already fixed by Arnd.
>> 	"iio: adc/imx25-gcq: move incorrect do_div"
> 
> It should. But I still have the same build failure with next-20160307
> and not only tilepro, even m32r is also having the same build failure.
> 
Lee, did you pick the original fix from Arnd up?

I can take this after the merge window if not.

Jonathan
> regards
> sudip
>

Thread

Re: [PATCH] iio: adc: imx25-gcq: fix do_div Jonathan Cameron <jic23@kernel.org> - 2016-03-05 19:50 +0100
  Re: [PATCH] iio: adc: imx25-gcq: fix do_div Markus Pargmann <mpa@pengutronix.de> - 2016-03-07 10:10 +0100
    Re: [PATCH] iio: adc: imx25-gcq: fix do_div Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-03-07 12:10 +0100
      Re: [PATCH] iio: adc: imx25-gcq: fix do_div Jonathan Cameron <jic23@kernel.org> - 2016-03-12 12:10 +0100
        Re: [PATCH] iio: adc: imx25-gcq: fix do_div Lee Jones <lee.jones@linaro.org> - 2016-03-16 09:50 +0100

csiph-web