Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1356366
| From | Peter Zijlstra <peterz@infradead.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH V6 0/6] Intel memory b/w monitoring support |
| Date | 2016-03-12 09:00 +0100 |
| Message-ID | <rbMCT-2IW-13@gated-at.bofh.it> (permalink) |
| References | <rbilr-5Ng-3@gated-at.bofh.it> <rbEch-4LU-11@gated-at.bofh.it> <rbH0u-6ZX-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Sat, Mar 12, 2016 at 01:56:13AM +0000, Luck, Tony wrote:
> Some tracing printk() show that we are calling update_sample() with totally bogus arguments.
>
> There are a few good calls, then I see rmid=-380863112 evt_type=-30689 first=0
>
> That turns into a wild vrmid, and we fault accessing mbm_current->prev_msr
It's because I'm a right idiot.. The below should sort that methinks.
Will push a new branch
--- a/arch/x86/events/intel/cqm.c
+++ b/arch/x86/events/intel/cqm.c
@@ -466,9 +466,9 @@ static bool is_mbm_event(int e)
static void cqm_mask_call(struct rmid_read *rr)
{
if (is_mbm_event(rr->evt_type))
- on_each_cpu_mask(&cqm_cpumask, __intel_mbm_event_count, &rr, 1);
+ on_each_cpu_mask(&cqm_cpumask, __intel_mbm_event_count, rr, 1);
else
- on_each_cpu_mask(&cqm_cpumask, __intel_cqm_event_count, &rr, 1);
+ on_each_cpu_mask(&cqm_cpumask, __intel_cqm_event_count, rr, 1);
}
/*
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH V6 0/6] Intel memory b/w monitoring support Vikas Shivappa <vikas.shivappa@linux.intel.com> - 2016-03-11 00:40 +0100
[PATCH 2/6] x86/perf/intel/cqm: Fix cqm memory leak and notifier leak Vikas Shivappa <vikas.shivappa@linux.intel.com> - 2016-03-11 00:40 +0100
Re: [PATCH V6 0/6] Intel memory b/w monitoring support Peter Zijlstra <peterz@infradead.org> - 2016-03-12 00:00 +0100
Re: [PATCH V6 0/6] Intel memory b/w monitoring support Vikas Shivappa <vikas.shivappa@intel.com> - 2016-03-12 00:30 +0100
Re: [PATCH V6 0/6] Intel memory b/w monitoring support Vikas Shivappa <vikas.shivappa@intel.com> - 2016-03-12 00:30 +0100
RE: [PATCH V6 0/6] Intel memory b/w monitoring support "Luck, Tony" <tony.luck@intel.com> - 2016-03-12 00:50 +0100
RE: [PATCH V6 0/6] Intel memory b/w monitoring support "Luck, Tony" <tony.luck@intel.com> - 2016-03-12 03:00 +0100
Re: [PATCH V6 0/6] Intel memory b/w monitoring support Peter Zijlstra <peterz@infradead.org> - 2016-03-12 09:00 +0100
RE: [PATCH V6 0/6] Intel memory b/w monitoring support "Luck, Tony" <tony.luck@intel.com> - 2016-03-12 17:20 +0100
csiph-web