Re: [PATCH v2] cpufreq: Make cpufreq_quick_get() safe to call.

From	Viresh Kumar <viresh.kumar@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] cpufreq: Make cpufreq_quick_get() safe to call.
Date	2016-03-12 01:00 +0100
Message-ID	<rbF8m-5sL-5@gated-at.bofh.it> (permalink)
References	<rbkZX-7ID-1@gated-at.bofh.it> <rbqVK-3vt-37@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 11-03-16, 09:43, Richard Cochran wrote:
> The function, cpufreq_quick_get, accesses the global 'cpufreq_driver' and
> its fields without taking the associated lock, cpufreq_driver_lock.
> 
> Without the locking, nothing guarantees that 'cpufreq_driver' remains
> consistent during the call.  This patch fixes the issue by taking the lock
> before accessing the data structure.
> 
> Cc: Dirk Brandewie <dirk.brandewie@gmail.com>
> Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> Cc: linux-pm@vger.kernel.org
> Signed-off-by: Richard Cochran <rcochran@linutronix.de>
> ---
>  drivers/cpufreq/cpufreq.c | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] cpufreq: Make cpufreq_quick_get() safe to call. Richard Cochran <rcochran@linutronix.de> - 2016-03-10 16:20 +0100
  Re: [PATCH] cpufreq: Make cpufreq_quick_get() safe to call. "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-03-10 23:20 +0100
    Re: [PATCH] cpufreq: Make cpufreq_quick_get() safe to call. "Rafael J. Wysocki" <rafael@kernel.org> - 2016-03-11 03:30 +0100
      [PATCH v2] cpufreq: Make cpufreq_quick_get() safe to call. Richard Cochran <rcochran@linutronix.de> - 2016-03-11 09:50 +0100
        Re: [PATCH v2] cpufreq: Make cpufreq_quick_get() safe to call. Viresh Kumar <viresh.kumar@linaro.org> - 2016-03-12 01:00 +0100

csiph-web