Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1356236

Re: [RFC PATCH 1/3] siox: new driver/bus framework for Eckelmann SIOX

Show all headers | View raw

On Fri, Mar 11, 2016 at 10:52:12PM +0100, Uwe Kleine-König wrote:
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  drivers/Kconfig          |   2 +
>  drivers/Makefile         |   1 +
>  drivers/siox/Kconfig     |   2 +
>  drivers/siox/Makefile    |   1 +
>  drivers/siox/siox-core.c | 572 +++++++++++++++++++++++++++++++++++++++++++++++
>  drivers/siox/siox.h      |  48 ++++
>  include/linux/siox.h     |  53 +++++
>  7 files changed, 679 insertions(+)
>  create mode 100644 drivers/siox/Kconfig
>  create mode 100644 drivers/siox/Makefile
>  create mode 100644 drivers/siox/siox-core.c
>  create mode 100644 drivers/siox/siox.h
>  create mode 100644 include/linux/siox.h

What's the relationship between your "master" and "regular" devices
here?  I think that's getting things confused, you are unregistering
your 'master' yet the children it controls don't go away because you
never unregister them.  You need to fix this heirachy up a bit, and
maybe just drop the 'master' logic?

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH 1/3] siox: new driver/bus framework for Eckelmann SIOX Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2016-03-11 23:00 +0100
  Re: [RFC PATCH 1/3] siox: new driver/bus framework for Eckelmann SIOX Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-03-11 23:30 +0100
    Re: [RFC PATCH 1/3] siox: new driver/bus framework for Eckelmann SIOX Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2016-03-12 14:50 +0100
      Re: [RFC PATCH 1/3] siox: new driver/bus framework for Eckelmann SIOX Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-03-13 04:50 +0100

csiph-web