Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1356128

Re: [BUG] Device unbound in a resumed state

Show all headers | View raw

On Fri, 11 Mar 2016, Krzysztof Kozlowski wrote:

> Hi,
> 
> 
> Could be related (the same?) with [0].
> 
> I have a driver (hwrng/exynos-rng) which in probe does:
> pm_runtime_set_autosuspend_delay(&pdev->dev, EXYNOS_AUTOSUSPEND_DELAY);
> pm_runtime_use_autosuspend(&pdev->dev);
> pm_runtime_enable(&pdev->dev);
> 
> and in remove:
> pm_runtime_disable(&pdev->dev)

But not pm_runtime_dont_use_autosuspend()?

Why disable runtime PM if you want the runtime-PM methods to put the 
device into a low-power state?

> Just before unbinding in __device_release_driver() the device is resumed
> but unfortunately not suspended later. I mean the
> __device_release_driver()->pm_runtime_put_sync() does not trigger
> runtime suspend.

Because autosuspend is still in use at this point.

> This leads to leaving the device in active state (e.g. clocks enabled).
> 
> It does not happen after removal of autosuspend. Also runtime suspend
> happens after very fast unbind-bind.

Overall it sounds like the system is behaving the way it is supposed 
to.

But maybe we should make pm_runtime_use_autosuspend() call
pm_runtime_mark_last_busy(), to avoid the unbind - bind - immediate
autosuspend behavior.

Alan Stern

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[BUG] Device unbound in a resumed state Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-03-11 08:10 +0100
  Re: [BUG] Device unbound in a resumed state Alan Stern <stern@rowland.harvard.edu> - 2016-03-11 19:50 +0100
    Re: [BUG] Device unbound in a resumed state Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-03-12 06:30 +0100

csiph-web