Re: [PATCH 1/3] net: thunderx: Cleanup PHY probing code.

From	Andrew Lunn <andrew@lunn.ch>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] net: thunderx: Cleanup PHY probing code.
Date	2016-03-11 20:10 +0100
Message-ID	<rbABI-2hR-23@gated-at.bofh.it> (permalink)
References	(1 earlier) <rbyqe-CG-21@gated-at.bofh.it> <rbzcC-1f1-15@gated-at.bofh.it> <rbzFE-1Ep-17@gated-at.bofh.it> <rbzFE-1Ep-15@gated-at.bofh.it> <rbABI-2hR-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> >I don't see why it should wait around forever. I have boards with
> >Marvell PHYs, yet if i don't build the Marvell driver, the Ethernet
> >driver still loads, because the generic PHY driver is used instead.
> >Why does this not work here?
> 
> As I said before, there is no driver for the device, so
> of_phy_find_device() will always return NULL.

I'm not yet convinced this is true. I really do expect that the
generic PHY driver will bind to it. It might then go horribly wrong,
because it is not standard compliant, but that is a different issue.

The generic driver should probably have a black list for such devices.
This is a PHY issue, not an MDIO issue, and the problem should be
solved in the PHY layer, not in one MDIO driver.

We should also consider what happens when somebody actually writes a
driver for this PHY. Are you not going to use it?

Before this patchset, you did not special case this compatible
string. So at the very least, you need to split this into a separate
patch, so the maintainers can ACK/NACK it, independent of the other
change it is embedded in.

       Andrew

Thread

[PATCH 0/3] net/phy: Improvements to Cavium Thunder MDIO code. David Daney <ddaney.cavm@gmail.com> - 2016-03-11 17:50 +0100
  [PATCH 1/3] net: thunderx: Cleanup PHY probing code. David Daney <ddaney.cavm@gmail.com> - 2016-03-11 17:50 +0100
    Re: [PATCH 1/3] net: thunderx: Cleanup PHY probing code. Andrew Lunn <andrew@lunn.ch> - 2016-03-11 18:40 +0100
      Re: [PATCH 1/3] net: thunderx: Cleanup PHY probing code. Andrew Lunn <andrew@lunn.ch> - 2016-03-11 19:10 +0100
        Re: [PATCH 1/3] net: thunderx: Cleanup PHY probing code. Andrew Lunn <andrew@lunn.ch> - 2016-03-11 20:10 +0100
          Re: [PATCH 1/3] net: thunderx: Cleanup PHY probing code. Florian Fainelli <f.fainelli@gmail.com> - 2016-03-11 20:40 +0100
            Re: [PATCH 1/3] net: thunderx: Cleanup PHY probing code. David Daney <ddaney.cavm@gmail.com> - 2016-03-11 22:00 +0100
              Re: [PATCH 1/3] net: thunderx: Cleanup PHY probing code. Andrew Lunn <andrew@lunn.ch> - 2016-03-11 22:40 +0100
  [PATCH 3/3] phy: mdio-thunder:  Add driver for Cavium Thunder SoC MDIO buses. David Daney <ddaney.cavm@gmail.com> - 2016-03-11 17:50 +0100
  [PATCH 2/3] phy: mdio-octeon: Refactor into two files/modules David Daney <ddaney.cavm@gmail.com> - 2016-03-11 17:50 +0100

csiph-web