[patch] ata: ahci_xgene: dereferencing uninitialized pointer in probe

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	[patch] ata: ahci_xgene: dereferencing uninitialized pointer in probe
Date	2016-03-10 08:50 +0100
Message-ID	<rb3w6-3HD-13@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

If the call to acpi_get_object_info() fails then "info" hasn't been
initialized.  In that situation, we already know that "version" should
be XGENE_AHCI_V1 so we don't actually need to dereference "info".

Fixes: c9802a4be661 ('ata: ahci_xgene: Add AHCI Support for 2nd HW version of APM X-Gene SoC AHCI SATA Host controller.')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/ata/ahci_xgene.c b/drivers/ata/ahci_xgene.c
index 8e3f7fa..73b19b2 100644
--- a/drivers/ata/ahci_xgene.c
+++ b/drivers/ata/ahci_xgene.c
@@ -821,9 +821,9 @@ static int xgene_ahci_probe(struct platform_device *pdev)
 				dev_warn(&pdev->dev, "%s: Error reading device info. Assume version1\n",
 					__func__);
 				version = XGENE_AHCI_V1;
-			}
-			if (info->valid & ACPI_VALID_CID)
+			} else if (info->valid & ACPI_VALID_CID) {
 				version = XGENE_AHCI_V2;
+			}
 		}
 	}
 #endif

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[patch] ata: ahci_xgene: dereferencing uninitialized pointer in probe Dan Carpenter <dan.carpenter@oracle.com> - 2016-03-10 08:50 +0100
  Re: [patch] ata: ahci_xgene: dereferencing uninitialized pointer in  probe Tejun Heo <tj@kernel.org> - 2016-03-11 18:50 +0100

csiph-web