Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1354877

Re: [kernel-hardening] Re: [PATCH v3 3/3] SROP mitigation: Add sysctl to disable SROP protection.

Show all headers | View raw

On Tue, Mar 8, 2016 at 1:00 PM, One Thousand Gnomes
<gnomes@lxorguk.ukuu.org.uk> wrote:
> On Tue,  8 Mar 2016 13:47:55 -0700
> Scott Bauer <sbauer@eng.utah.edu> wrote:
>
>> This patch adds a sysctl argument to disable SROP protection.
>
> Shouldn't it be a sysctl to enable it irrevocably, otherwise if I have DAC
> capability I can turn off SROP and attack something to get to higher
> capability levels ?
>
> (The way almost all distros are set up its kind of academic but for a
> properly secured system it might matter).

Perhaps use proc_dointvec_minmax_sysadmin instead to tie changes
strictly to CAP_SYS_ADMIN?

-Kees

>
> Alan



-- 
Kees Cook
Chrome OS & Brillo Security

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 3/3] SROP mitigation: Add sysctl to disable SROP protection. Scott Bauer <sbauer@eng.utah.edu> - 2016-03-08 21:50 +0100
  Re: [PATCH v3 3/3] SROP mitigation: Add sysctl to disable SROP  protection. One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> - 2016-03-08 22:10 +0100
    Re: [kernel-hardening] Re: [PATCH v3 3/3] SROP mitigation: Add sysctl  to disable SROP protection. Kees Cook <keescook@chromium.org> - 2016-03-10 07:40 +0100
      Re: [kernel-hardening] Re: [PATCH v3 3/3] SROP mitigation: Add sysctl  to disable SROP protection. Andy Lutomirski <luto@amacapital.net> - 2016-03-10 07:50 +0100

csiph-web