Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1354882
| Path | csiph.com!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Ravishankar Karkala Mallikarjunayya <ravishankarkm32@gmail.com> |
| Newsgroups | linux.kernel |
| Subject | [PATCH 2/5] Staging: comedi: fix WARNING issue in s626.c |
| Date | Thu, 10 Mar 2016 08:00:01 +0100 |
| Message-ID | <rb2JH-39Z-5@gated-at.bofh.it> (permalink) |
| References | <rb2JH-39Z-3@gated-at.bofh.it> |
| X-Original-To | abbotti@mev.co.uk |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=6svDJGy0MlBs38MTuTE/TbwAJO0s3f1q+xy2FX/kU/M=; b=RkLc/nksIwN0KOToC7Eg8RQAy7sDgqTeIgqN1vm5ui5Poixt7bCrxD+sPPhpEjNArp AF6anr0nhQXVGeuQYZS7cw9PKr5J/GnVq29or7I3jLB4a/2BwvDGhFaR76MWJNNqaNVa ZB8beVs8chb4+GnkHkr970JChaJaUrX7PkxoGGiYh6ZP4M/GFMB9LPnMgGv9jjkLJ4Mu UHF26F49GzQ3FowYHP91EgTlzq6p/wJWfvxyXW5rkprWnsz438l3z3AMpQqA1fLRJWIk e/Dky5HqnFfRymMbPhxednB2U4O3w67FwRu+KUexaLe3+5AvpXdRza+GCtu33wvuyqgg flSA== |
| X-Google-Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=6svDJGy0MlBs38MTuTE/TbwAJO0s3f1q+xy2FX/kU/M=; b=dcwCZUUpzXvoc6faNjl1Iyj3ze0JTyt3IiSrihxFngQ+OqpMLOgk7KBoqwtQdpuZJg 7O97sdJuvxh8N50wtZz6d4DZ9dVBIYe3nD9b25i/+6seB0ubG/RkrffTqLZCFMzocarv 6LqHqw1Rh77ZeCi4qIUmWraPN7w7SO77nww410efCj6eV0Vop0oT6ojxhc/h95JqX/xy fpp7LAkJwuaRr27QzzEMpRelQqMgnNX/H6bRgbCsmnZNsTUb6c4H1ISv9d3/+5EGIuOt XUfepxqNLS1iqV8tURTCmiRefOVTnqUV48e0vrXLQNoPeR+L9Z1W9YjZDqfmn7t4L0mO g1Zg== |
| X-Gm-Message-State | AD7BkJJK3ZoiqW8RfKQUat/csadQMnjXquBh/qb4nhnZI63ltbJfHRPNkLA2FhLXH3Uj7g== |
| X-Received | by 10.98.34.205 with SMTP id p74mr2666827pfj.93.1457592795448; Wed, 09 Mar 2016 22:53:15 -0800 (PST) |
| X-Mailer | git-send-email 1.9.1 |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 76 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | hsweeten@visionengravers.com, gregkh@linuxfoundation.org, geliangtang@163.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Ravishankar Karkala Mallikarjunayya <ravishankarkm32@gmail.com> |
| X-Original-Date | Thu, 10 Mar 2016 12:22:07 +0530 |
| X-Original-Message-ID | <1457592730-14347-2-git-send-email-ravishankarkm32@gmail.com> |
| X-Original-References | <1457592730-14347-1-git-send-email-ravishankarkm32@gmail.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1354882 |
Show key headers only | View raw
This is a patch to the s626.c file that fixes up a Block comments issues
found by the checkpatch.pl tool.
i.e. Block comments use a trailing */ on a separate line
Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankarkm32@gmail.com>
---
drivers/staging/comedi/drivers/s626.c | 38 ++++++++++++++++++++++-------------
1 file changed, 24 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/comedi/drivers/s626.c b/drivers/staging/comedi/drivers/s626.c
index 5469ca0..6ebae3a 100644
--- a/drivers/staging/comedi/drivers/s626.c
+++ b/drivers/staging/comedi/drivers/s626.c
@@ -77,23 +77,30 @@ struct s626_buffer_dma {
struct s626_private {
u8 ai_cmd_running; /* ai_cmd is running */
unsigned int ai_sample_timer; /* time between samples in
- * units of the timer */
+ * units of the timer
+ */
int ai_convert_count; /* conversion counter */
unsigned int ai_convert_timer; /* time between conversion in
- * units of the timer */
- u16 counter_int_enabs; /* counter interrupt enable mask
- * for MISC2 register */
+ * units of the timer
+ */
+ u16 counter_int_enabs; /* counter interrupt enable mask
+ * for MISC2 register
+ */
u8 adc_items; /* number of items in ADC poll list */
struct s626_buffer_dma rps_buf; /* DMA buffer used to hold ADC (RPS1)
- * program */
+ * program
+ */
struct s626_buffer_dma ana_buf; /* DMA buffer used to receive ADC data
- * and hold DAC data */
- u32 *dac_wbuf; /* pointer to logical adrs of DMA buffer
- * used to hold DAC data */
+ * and hold DAC data
+ */
+ u32 *dac_wbuf; /* pointer to logical adrs of DMA buffer
+ * used to hold DAC data
+ */
u16 dacpol; /* image of DAC polarity register */
u8 trim_setpoint[12]; /* images of TrimDAC setpoints */
- u32 i2c_adrs; /* I2C device address for onboard EEPROM
- * (board rev dependent) */
+ u32 i2c_adrs; /* I2C device address for onboard EEPROM
+ * (board rev dependent)
+ */
};
/* Counter overflow/index event flag masks for RDMISC2. */
@@ -572,11 +579,14 @@ static int s626_set_dac(struct comedi_device *dev,
* running after the packet has been sent to the target DAC.
*/
val = 0x0F000000; /* Continue clock after target DAC data
- * (write to non-existent trimdac). */
+ * (write to non-existent trimdac).
+ */
val |= 0x00004000; /* Address the two main dual-DAC devices
- * (TSL's chip select enables target device). */
- val |= ((u32)(chan & 1) << 15); /* Address the DAC channel
- * within the device. */
+ * (TSL's chip select enables target device).
+ */
+ val |= ((u32)(chan & 1) << 15); /* Address the DAC channel
+ * within the device.
+ */
val |= (u32)dacdata; /* Include DAC setpoint data. */
return s626_send_dac(dev, val);
}
--
1.9.1
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH 2/5] Staging: comedi: fix WARNING issue in s626.c Ravishankar Karkala Mallikarjunayya <ravishankarkm32@gmail.com> - 2016-03-10 08:00 +0100 Re: [PATCH 2/5] Staging: comedi: fix WARNING issue in s626.c Greg KH <gregkh@linuxfoundation.org> - 2016-03-11 04:40 +0100
csiph-web