Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1354848

Re: [PATCH net-next] bpf: avoid copying junk bytes in bpf_get_current_comm()

Show all headers | View raw

From: Alexei Starovoitov <ast@fb.com>
Date: Wed, 9 Mar 2016 20:02:33 -0800

> Lots of places in the kernel use memcpy(buf, comm, TASK_COMM_LEN); but
> the result is typically passed to print("%s", buf) and extra bytes
> after zero don't cause any harm.
> In bpf the result of bpf_get_current_comm() is used as the part of
> map key and was causing spurious hash map mismatches.
> Use strlcpy() to guarantee zero-terminated string.
> bpf verifier checks that output buffer is zero-initialized,
> so even for short task names the output buffer don't have junk bytes.
> Note it's not a security concern, since kprobe+bpf is root only.
> 
> Fixes: ffeedafbf023 ("bpf: introduce current->pid, tgid, uid, gid, comm accessors")
> Reported-by: Tobias Waldekranz <tobias@waldekranz.com>
> Signed-off-by: Alexei Starovoitov <ast@kernel.org>
> ---
> Targeting net-next, since it's too late for net.
> I think it makes sense for stable as well.

Applied and queued up for -stable, thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH net-next] bpf: avoid copying junk bytes in bpf_get_current_comm() Alexei Starovoitov <ast@fb.com> - 2016-03-10 05:10 +0100
  Re: [PATCH net-next] bpf: avoid copying junk bytes in  bpf_get_current_comm() David Miller <davem@davemloft.net> - 2016-03-10 05:30 +0100
  Re: [PATCH net-next] bpf: avoid copying junk bytes in bpf_get_current_comm() Daniel Borkmann <daniel@iogearbox.net> - 2016-03-11 11:30 +0100
    Re: [PATCH net-next] bpf: avoid copying junk bytes in  bpf_get_current_comm() Alexei Starovoitov <ast@fb.com> - 2016-03-11 18:30 +0100
      Re: [PATCH net-next] bpf: avoid copying junk bytes in bpf_get_current_comm() Daniel Borkmann <daniel@iogearbox.net> - 2016-03-11 19:10 +0100
        Re: [PATCH net-next] bpf: avoid copying junk bytes in  bpf_get_current_comm() Alexei Starovoitov <ast@fb.com> - 2016-03-11 19:40 +0100

csiph-web