Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1353450

Re: [PATCH] pmem: don't allocate unused major device number

Show key headers only | View raw

On Tue, Mar 8, 2016 at 2:21 PM, NeilBrown <neilb@suse.com> wrote:
>
> When alloc_disk(0) or alloc_disk-node(0, XX) is used, the ->major
> number is completely ignored:  all devices are allocated with a
> major of BLOCK_EXT_MAJOR.
>
> So there is no point allocating pmem_major.
>
> Signed-off-by: NeilBrown <neilb@suse.com>
> ---
>  drivers/nvdimm/pmem.c | 19 +------------------
>  1 file changed, 1 insertion(+), 18 deletions(-)
>
> Hi Dan et al,
>  I was recently educating myself about the behavior of alloc_disk(0).
>  As I understand it, the ->major is ignored and all device numbers for all
>  partitions (including '0') are allocated on demand with major number of
>  BLOCK_EXT_MAJOR.
>
>  So I was a little surprised to find that pmem.c allocated a major
>  number which is never used - historical anomaly I suspect.
>  I was a bit more surprised at the comment in:
>
>   Commit: 9f53f9fa4ad1 ("libnvdimm, pmem: add libnvdimm support to the pmem driver")
>
>  "The minor numbers are also more predictable by passing 0 to alloc_disk()."
>
>  How can they possibly be more predictable given that they are allocated
>  on-demand?  Maybe discovery order is very predictable???

Ross, I remember you looked into this when Boaz pointed out something similar.

>  In any case, I propose this patch but cannot test it (beyond compiling)
>  as I don't have relevant hardware.  And maybe some user-space code greps
>  /proc/devices for "pmem" to determine if "pmem" is compiled in (though
>  I sincerely hope not).
>  So I cannot be certain that this patch won't break anything, but am
>  hoping that if you like it you might test it.

Will do.

Thanks Neil!

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] pmem: don't allocate unused major device number NeilBrown <neilb@suse.com> - 2016-03-08 23:30 +0100
  Re: [PATCH] pmem: don't allocate unused major device number Dan Williams <dan.j.williams@intel.com> - 2016-03-08 23:40 +0100
    Re: [PATCH] pmem: don't allocate unused major device number Ross Zwisler <ross.zwisler@linux.intel.com> - 2016-03-09 20:00 +0100
  Re: [PATCH] pmem: don't allocate unused major device number Dan Williams <dan.j.williams@intel.com> - 2016-03-09 20:30 +0100

csiph-web