Re: [PATCH 3/3] ARM: bcm2835: Add VC4 to the device tree.

From	Stephen Warren <swarren@wwwdotorg.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] ARM: bcm2835: Add VC4 to the device tree.
Date	2016-03-08 19:20 +0100
Message-ID	<rauoG-4zc-9@gated-at.bofh.it> (permalink)
References	<r94FX-3Op-3@gated-at.bofh.it> <r94FY-3Op-13@gated-at.bofh.it> <raj0d-5qh-13@gated-at.bofh.it> <raueZ-4va-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 03/08/2016 11:04 AM, Eric Anholt wrote:
> Stephen Warren <swarren@wwwdotorg.org> writes:
>
>> On 03/04/2016 01:32 PM, Eric Anholt wrote:
>>> VC4 is the GPU (display and 3D) present on the 283x.
>>
>>> diff --git a/arch/arm/boot/dts/bcm2835-rpi-a-plus.dts b/arch/arm/boot/dts/bcm2835-rpi-a-plus.dts
>>
>>> +&hdmi {
>>> +	hpd-gpios = <&gpio 46 GPIO_ACTIVE_LOW>;
>>> +};
>>
>> Isn't that the same everywhere? If so, adding it to bcm2835-rpi.dtsi
>> seems like a better idea; it'd avoid duplicating it everywhere.
>
> It's not the same everywhere (_HIGH vs _LOW), which is why it's in the
> individual files.

Oh right, it looks OK then. The series,
Acked-by: Stephen Warren <swarren@wwwdotorg.org>

One could reduce the duplication by moving the common block into the 
common .dtsi file, but using a board-defined #define for the polarity:

bcm2835-rpi-a-plus.dts:

#define RPI_HDMI_HPD_POLARITY
#include "bcm2835-rpi.dtsi"

bcm2835-rpi.dtsi:

&hdmi {
	hpd-gpios = <&gpio 46 RPI_HDMI_HPD_POLARITY>;
};

... although this case is so tiny I'm not sure there's any benefit 
trying to unify it like that right now.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] ARM: bcm2835: Include VC4 GPU in the DT Eric Anholt <eric@anholt.net> - 2016-03-04 21:40 +0100
  [PATCH 3/3] ARM: bcm2835: Add VC4 to the device tree. Eric Anholt <eric@anholt.net> - 2016-03-04 21:40 +0100
    Re: [PATCH 3/3] ARM: bcm2835: Add VC4 to the device tree. Stephen Warren <swarren@wwwdotorg.org> - 2016-03-08 07:10 +0100
      Re: [PATCH 3/3] ARM: bcm2835: Add VC4 to the device tree. Eric Anholt <eric@anholt.net> - 2016-03-08 19:10 +0100
        Re: [PATCH 3/3] ARM: bcm2835: Add VC4 to the device tree. Stephen Warren <swarren@wwwdotorg.org> - 2016-03-08 19:20 +0100

csiph-web