Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1353097

Re: [PATCH 3/5] gpio: of: Return error if gpio hog configuration failed

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Tue, Mar 08, 2016 at 05:32:06PM +0530, Laxman Dewangan wrote:
> If GPIO hog configuration failed while adding OF based
> gpiochip() then return the error instead of ignoring it.
> 
> This helps of properly handling the gpio driver dependency.
> 
> When adding the gpio hog nodes for NVIDIA's Tegra210 platforms,
> the gpio_hogd() fails with EPROBE_DEFER because pinctrl is not
> ready at this time and gpio_request() for Tegra GPIO driver
> returns error. The error was not causing the Tegra GPIO driver
> to fail as the error was getting ignored.
> 
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> Cc: Benoit Parrot <bparrot@ti.com>
> Cc: Alexandre Courbot <acourbot@nvidia.com>
> ---
>  drivers/gpio/gpiolib-of.c | 15 +++++++++------
>  1 file changed, 9 insertions(+), 6 deletions(-)

Reviewed-by: Thierry Reding <treding@nvidia.com>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] gpio: of: Add error handling and support for multiple gpio in gpio-hog Laxman Dewangan <ldewangan@nvidia.com> - 2016-03-08 13:20 +0100
  [PATCH 3/5] gpio: of: Return error if gpio hog configuration failed Laxman Dewangan <ldewangan@nvidia.com> - 2016-03-08 13:20 +0100
    Re: [PATCH 3/5] gpio: of: Return error if gpio hog configuration  failed Thierry Reding <treding@nvidia.com> - 2016-03-08 15:30 +0100
    Re: [PATCH 3/5] gpio: of: Return error if gpio hog configuration  failed Stephen Warren <swarren@wwwdotorg.org> - 2016-03-09 18:20 +0100
      Re: [PATCH 3/5] gpio: of: Return error if gpio hog configuration  failed Laxman Dewangan <ldewangan@nvidia.com> - 2016-03-10 08:20 +0100

csiph-web