Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1352822

Re: [PATCH RESEND] Documentation: devicetree: Clean up gpio-keys example

Show all headers | View raw

Am 08.03.2016 um 09:54 schrieb Geert Uytterhoeven:
> On Mon, Mar 7, 2016 at 7:24 PM, Andreas Färber <afaerber@suse.de> wrote:
>> Drop #address-cells and #size-cells, which are not required by the
>> gpio-keys binding documentation, as button sub-nodes are not devices.
>>
>> Reported-by: Julien Chauveau <chauveau.julien@gmail.com>
>> Signed-off-by: Andreas Färber <afaerber@suse.de>
>> ---
>>  Documentation/devicetree/bindings/input/gpio-keys.txt | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/input/gpio-keys.txt b/Documentation/devicetree/bindings/input/gpio-keys.txt
>> index 21641236c095..1552a11f6786 100644
>> --- a/Documentation/devicetree/bindings/input/gpio-keys.txt
>> +++ b/Documentation/devicetree/bindings/input/gpio-keys.txt
>> @@ -34,8 +34,6 @@ Example nodes:
>>
>>         gpio_keys {

While at it, I was told the preferred node naming would be dashes, not
underscores. The deeper we dig, the more we find.

>>                         compatible = "gpio-keys";
>> -                       #address-cells = <1>;
>> -                       #size-cells = <0>;
>>                         autorepeat;

Also a white line here may be optically more pleasant.

>>                         button@21 {
> 
> FYI, with "[PATCH] scripts/dtc: Update to upstream version 53bf130b1cdd":
> (http://www.spinics.net/lists/devicetree/msg117206.html) applied:
> 
> Warning (unit_address_vs_reg): Node /keyboard/button@21 has a unit
> name, but no reg property

My v2 GeekBox patch did have *-cells and a reg property, but Julien
asked I drop that: https://patchwork.kernel.org/patch/8246481/

Are you suggesting we should add a reg property here and drop this patch
or go with this patch but follow up to not use @21?

> 
>>                                 label = "GPIO Key UP";

Regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH RESEND] Documentation: devicetree: Clean up gpio-keys example Andreas Färber <afaerber@suse.de> - 2016-03-07 19:30 +0100
  Re: [PATCH RESEND] Documentation: devicetree: Clean up gpio-keys example Javier Martinez Canillas <javier@dowhile0.org> - 2016-03-07 19:40 +0100
    Re: [PATCH RESEND] Documentation: devicetree: Clean up gpio-keys  example Andreas Färber <afaerber@suse.de> - 2016-03-07 20:30 +0100
  Re: [PATCH RESEND] Documentation: devicetree: Clean up gpio-keys example Geert Uytterhoeven <geert@linux-m68k.org> - 2016-03-08 10:00 +0100
    Re: [PATCH RESEND] Documentation: devicetree: Clean up gpio-keys example Julien Chauveau <chauveau.julien@gmail.com> - 2016-03-08 10:50 +0100
      Re: [PATCH RESEND] Documentation: devicetree: Clean up gpio-keys  example Andreas Färber <afaerber@suse.de> - 2016-03-08 11:20 +0100
        Re: [PATCH RESEND] Documentation: devicetree: Clean up gpio-keys example Julien Chauveau <chauveau.julien@gmail.com> - 2016-03-11 00:10 +0100
    Re: [PATCH RESEND] Documentation: devicetree: Clean up gpio-keys  example Andreas Färber <afaerber@suse.de> - 2016-03-08 11:10 +0100
      Re: [PATCH RESEND] Documentation: devicetree: Clean up gpio-keys example Julien Chauveau <chauveau.julien@gmail.com> - 2016-03-11 00:10 +0100

csiph-web