Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1352558
| From | Kefeng Wang <wangkefeng.wang@huawei.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2] locktorture: Fix NULL pointer when torture_type is invalid |
| Date | 2016-03-08 03:20 +0100 |
| Message-ID | <rafpE-2SQ-11@gated-at.bofh.it> (permalink) |
| References | (6 earlier) <r8wXF-4lu-39@gated-at.bofh.it> <r9SMr-4VR-17@gated-at.bofh.it> <r9Wdj-7a3-7@gated-at.bofh.it> <r9XsK-86J-7@gated-at.bofh.it> <ra5qi-4EI-23@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 2016/3/7 21:37, Paul E. McKenney wrote: > On Mon, Mar 07, 2016 at 03:02:05PM +0800, Kefeng Wang wrote: >> >> >> On 2016/3/7 13:40, Davidlohr Bueso wrote: >>> On Mon, 07 Mar 2016, Kefeng Wang wrote: >>>> On 2016/3/3 16:36, Davidlohr Bueso wrote: >>> >>>>> + /* >>>>> + * Indicates early cleanup, meaning that the test has not run, >>>>> + * such as when passing bogus args when loading the module. As >>>>> + * such, only perform the underlying torture-specific cleanups, >>>>> + * and avoid anything related to locktorture. >>>>> + */ >>>>> + if (!cxt.lwsa) >>>>> + goto end; >>>> >>>> Sorry for the late response, the cxt.lrsa should be taken into account too. >>> >>> I am taking it into account, note that we kfree lwsa if lrsa fails memory >>> allocation. Of course we should be defensive, so go ahead and explicitly set >>> it to nil. v2 below, otherwise same patch. >> >> This one looks good, and tested on my board. > > Very good! May we add your Tested-by? Sure, please. > > Thanx, Paul
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH v2] locktorture: Fix NULL pointer when torture_type is invalid Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-03-07 03:10 +0100
Re: [PATCH v2] locktorture: Fix NULL pointer when torture_type is invalid Davidlohr Bueso <dave@stgolabs.net> - 2016-03-07 06:50 +0100
Re: [PATCH v2] locktorture: Fix NULL pointer when torture_type is invalid Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-03-07 08:10 +0100
Re: [PATCH v2] locktorture: Fix NULL pointer when torture_type is invalid "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-03-07 16:40 +0100
Re: [PATCH v2] locktorture: Fix NULL pointer when torture_type is invalid Kefeng Wang <wangkefeng.wang@huawei.com> - 2016-03-08 03:20 +0100
Re: [PATCH v2] locktorture: Fix NULL pointer when torture_type is invalid "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-03-08 21:00 +0100
csiph-web