Re: [PATCH][RFC v3] ACPI / PM: Fix poweroff issue on HW-full platforms without _S5

From	"Rafael J. Wysocki" <rjw@rjwysocki.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH][RFC v3] ACPI / PM: Fix poweroff issue on HW-full platforms without _S5
Date	2016-03-08 03:00 +0100
Message-ID	<raf6i-2wB-9@gated-at.bofh.it> (permalink)
References	<r9Tp7-5aA-3@gated-at.bofh.it> <ra3eP-3jo-7@gated-at.bofh.it> <ra5JE-4Li-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Monday, March 07, 2016 03:53:13 PM Chen, Yu C wrote:
> Hi Rafael,
> (resend for broken content)
> 
> > -----Original Message-----
> > From: rjwysocki@gmail.com [mailto:rjwysocki@gmail.com] On Behalf Of
> > Rafael J. Wysocki
> > Sent: Monday, March 07, 2016 9:19 PM
> > To: Chen, Yu C
> > Cc: ACPI Devel Maling List; x86@kernel.org; linux-efi@vger.kernel.org; Linux
> > Kernel Mailing List; linux-pm@vger.kernel.org; Rafael J. Wysocki; Len Brown;
> > Matt Fleming; Thomas Gleixner; Ingo Molnar; H. Peter Anvin; Zhang, Rui
> > Subject: Re: [PATCH][RFC v3] ACPI / PM: Fix poweroff issue on HW-full
> > platforms without _S5
> > 
> [cut]
> > >  bool efi_poweroff_required(void)
> > >  {
> > > -       return !!acpi_gbl_reduced_hardware;
> > > +       return acpi_gbl_reduced_hardware || (acpi_no_s5 &&
> > > + !pm_power_off);
> > 
> > What if CONFIG_ACPI is not set here?
> If CONFIG_ACPI is not set, this file would not 
> be compiled, because CONFIG_EFI depends on CONFIG_ACPI.

OK

So the next question will be if efi_poweroff_required() is guaranteed to run
after all of the other code that may register alternative power off handling.

Thanks,
Rafael

Thread

[PATCH][RFC v3] ACPI / PM: Fix poweroff issue on HW-full platforms without _S5 Chen Yu <yu.c.chen@intel.com> - 2016-03-07 03:50 +0100
  Re: [PATCH][RFC v3] ACPI / PM: Fix poweroff issue on HW-full  platforms without _S5 "Rafael J. Wysocki" <rafael@kernel.org> - 2016-03-07 14:20 +0100
    RE: [PATCH][RFC v3] ACPI / PM: Fix poweroff issue on HW-full  platforms without _S5 "Chen, Yu C" <yu.c.chen@intel.com> - 2016-03-07 16:50 +0100
    RE: [PATCH][RFC v3] ACPI / PM: Fix poweroff issue on HW-full  platforms without _S5 "Chen, Yu C" <yu.c.chen@intel.com> - 2016-03-07 17:00 +0100
      Re: [PATCH][RFC v3] ACPI / PM: Fix poweroff issue on HW-full platforms without _S5 "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-03-08 03:00 +0100
        RE: [PATCH][RFC v3] ACPI / PM: Fix poweroff issue on HW-full  platforms without _S5 "Chen, Yu C" <yu.c.chen@intel.com> - 2016-03-08 17:30 +0100
          Re: [PATCH][RFC v3] ACPI / PM: Fix poweroff issue on HW-full platforms without _S5 "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-03-09 00:00 +0100
            RE: [PATCH][RFC v3] ACPI / PM: Fix poweroff issue on HW-full  platforms without _S5 "Chen, Yu C" <yu.c.chen@intel.com> - 2016-03-10 03:20 +0100
          Re: [PATCH][RFC v3] ACPI / PM: Fix poweroff issue on HW-full  platforms without _S5 Matt Fleming <matt@codeblueprint.co.uk> - 2016-03-09 16:40 +0100
            RE: [PATCH][RFC v3] ACPI / PM: Fix poweroff issue on HW-full  platforms without _S5 "Chen, Yu C" <yu.c.chen@intel.com> - 2016-03-10 03:30 +0100

csiph-web