Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1352544

Re: [PATCH v2 1/2] cxl: Add mechanism for delivering AFU driver specific events

Show all headers | View raw

Excerpts from Matt Ochs's message of 2016-03-08 11:26:55 +1100:
> Any reason for adding these extra lines as part of this commit?

mpe asked for some newlines here in the v1 submission, and it only
really made sense to do so if all the related sections had consistent
whitespace as well.

> > +/*
> > + * AFU driver ops allows an AFU driver to create their own events to pass to
> > + * userspace through the file descriptor as a simpler alternative to overriding
> > + * the read() and poll() calls that works with the generic cxl events. These
> > + * events are given priority over the generic cxl events, so will be delivered
> 
> so _they_ will be delivered

thanks for spotting that...

> > + *
> > + * even_pending() will be called by the cxl driver to check if an event is
> > + * pending (e.g. in select/poll/read calls).
> 
> event_pending() <- missing 't'

...and that.

Cheers,
-Ian

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/2] cxl: Add mechanism for delivering AFU driver specific events "Ian Munsie" <imunsie@au1.ibm.com> - 2016-03-07 20:10 +0100
  Re: [PATCH v2 1/2] cxl: Add mechanism for delivering AFU driver specific events Matt Ochs <mrochs@us.ibm.com> - 2016-03-08 01:30 +0100
    Re: [PATCH v2 1/2] cxl: Add mechanism for delivering AFU driver specific events Ian Munsie <imunsie@au1.ibm.com> - 2016-03-08 02:50 +0100

csiph-web