Re: [PATCH v2 0/6] leds: Use devm_led_classdev_register

From	Jacek Anaszewski <j.anaszewski@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 0/6] leds: Use devm_led_classdev_register
Date	2016-03-09 16:30 +0100
Message-ID	<raOdJ-1eq-23@gated-at.bofh.it> (permalink)
References	<raCYW-1Zn-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Amitoj,

On 03/09/2016 04:23 AM, Amitoj Kaur Chawla wrote:
> Switch to resource-managed function devm_led_classdev_register instead
> of led_classdev_register and remove unneeded led_classdev_unregister.
>
> The Coccinelle semantic patch used to make this change is as follows:
> //<smpl>
> @platform@
> identifier p, probefn, removefn;
> @@
> struct platform_driver p = {
>    .probe = probefn,
>    .remove = removefn,
> };
>
> @prb@
> identifier platform.probefn, pdev;
> expression e;
> @@
> probefn(struct platform_device *pdev, ...) {
>    ...
>    e =
> - led_classdev_register
> + devm_led_classdev_register
>    (...);
>     ...
> ?- led_classdev_unregister(...);
>    ...
> }
> @remove depends on prb@
> identifier platform.removefn;
> @@
> removefn(...) {
> ...
> ?- led_classdev_unregister(...);
> ...
> }
> //</smpl>
>
> Amitoj Kaur Chawla (6):
>    leds: 88pm860x: Use devm_led_classdev_register
>    leds: lp8788: Use devm_led_classdev_register
>    leds: wm831x-status: Use devm_led_classdev_register
>    leds: s3c24xx: Use devm_led_classdev_register
>    leds: da903x: Use devm_led_classdev_register
>    leds: max8997: Use devm_led_classdev_register
>
> Changes in v2:
>          -Patches 1-6: Remove unnecessary platform_set_drvdata
>          -Patch 4: Remove unnecessary pdev_to_gpio function definition
>
>   drivers/leds/leds-88pm860x.c      | 12 +-----------
>   drivers/leds/leds-da903x.c        | 12 +-----------
>   drivers/leds/leds-lp8788.c        | 14 +-------------
>   drivers/leds/leds-max8997.c       | 14 +-------------
>   drivers/leds/leds-s3c24xx.c       | 19 +------------------
>   drivers/leds/leds-wm831x-status.c | 13 +------------
>   6 files changed, 6 insertions(+), 78 deletions(-)
>

Thanks for the updated set. All patches have been applied
to the linux-leds.git.

-- 
Best regards,
Jacek Anaszewski

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/6] leds: Use devm_led_classdev_register Amitoj Kaur Chawla <amitoj1606@gmail.com> - 2016-03-09 04:30 +0100
  [PATCH v2 3/6] leds: wm831x-status: Use devm_led_classdev_register Amitoj Kaur Chawla <amitoj1606@gmail.com> - 2016-03-09 04:30 +0100
  [PATCH v2 6/6] leds: max8997: Use devm_led_classdev_register Amitoj Kaur Chawla <amitoj1606@gmail.com> - 2016-03-09 04:30 +0100
  [PATCH v2 4/6] leds: s3c24xx: Use devm_led_classdev_register Amitoj Kaur Chawla <amitoj1606@gmail.com> - 2016-03-09 04:30 +0100
  [PATCH v2 2/6] leds: lp8788: Use devm_led_classdev_register Amitoj Kaur Chawla <amitoj1606@gmail.com> - 2016-03-09 04:30 +0100
  [PATCH v2 1/6] leds: 88pm860x: Use devm_led_classdev_register Amitoj Kaur Chawla <amitoj1606@gmail.com> - 2016-03-09 04:30 +0100
  Re: [PATCH v2 0/6] leds: Use devm_led_classdev_register Jacek Anaszewski <j.anaszewski@samsung.com> - 2016-03-09 16:30 +0100

csiph-web