Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1354234

Re: [PATCH v2 0/5] introduce kcompactd and stop compacting in kswapd

Show all headers | View raw

On Mon 08-02-16 14:38:06, Vlastimil Babka wrote:
> The previous RFC is here [1]. It didn't have a cover letter, so the description
> and results are in the individual patches.

FWIW I think this is a step in the right direction. I would give my
Acked-by to all patches but I wasn't able to find time for a deep review
and my lack of knowledge of compaction details doesn't help much. I do
agree that conflating kswapd with compaction didn't really work out well
and fixing this would just make the code more complex and would more
prone to new bugs. In future we might want to invent something similar
to watermarks and set an expected level of high order pages prepared for
the allocation (e.g. have at least XMB of memory in order-9+). kcompact
then could try as hard as possible to provide them. Does that sound at
least doable?

Thanks!
-- 
Michal Hocko
SUSE Labs

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 0/5] introduce kcompactd and stop compacting in kswapd Michal Hocko <mhocko@kernel.org> - 2016-03-09 17:00 +0100
  Re: [PATCH v2 0/5] introduce kcompactd and stop compacting in kswapd Vlastimil Babka <vbabka@suse.cz> - 2016-03-10 09:40 +0100

csiph-web