Re: [PATCH 1/3] thermal: of-thermal: Add devm version of thermal_zone_of_sensor_register

From	Laxman Dewangan <ldewangan@nvidia.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] thermal: of-thermal: Add devm version of thermal_zone_of_sensor_register
Date	2016-03-09 13:30 +0100
Message-ID	<raLpw-7PW-23@gated-at.bofh.it> (permalink)
References	<r8YqS-7AF-5@gated-at.bofh.it> <r8YqT-7AF-19@gated-at.bofh.it> <raxwd-6Ct-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Edurado,
Thanks for review.


On Wednesday 09 March 2016 02:59 AM, Eduardo Valentin wrote:
> Hello Laxman,
>
>
> Minor as follows.
>
> Can you please run ./scripts/checkpatch.pl --strict on this and remove
> the warnings, errors, checks?

Taken from existing function and so borrowed the error. Will fix in next 
revision.


>
> On Fri, Mar 04, 2016 at 07:10:08PM +0530, Laxman Dewangan wrote:
>> Add resource managed version of thermal_zone_of_sensor_register() and
>> thermal_zone_of_sensor_unregister().
>>
>> This helps in reducing the code size in error path, remove of
>> driver remove callbacks and making proper sequence for deallocations.
>>
>> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
>> ---
>>   drivers/thermal/of-thermal.c | 81 ++++++++++++++++++++++++++++++++++++++++++++
>>   include/linux/thermal.h      | 18 ++++++++++
> Could you also please document these under
> Documentation/thermal/sysfs-api.txt?
>
>
Sure, I saw that thermal_zone_of_sensor_register/unregister is also not 
documented.
So I will add the details for this first and then add for newly added 
interfaces.

Will take care in next series.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] thermal: add devm_ version of thermal_zone register and driver for max77620 Laxman Dewangan <ldewangan@nvidia.com> - 2016-03-04 15:00 +0100
  [PATCH 1/3] thermal: of-thermal: Add devm version of thermal_zone_of_sensor_register Laxman Dewangan <ldewangan@nvidia.com> - 2016-03-04 15:00 +0100
    Re: [PATCH 1/3] thermal: of-thermal: Add devm version of  thermal_zone_of_sensor_register Eduardo Valentin <edubezval@gmail.com> - 2016-03-08 22:40 +0100
      Re: [PATCH 1/3] thermal: of-thermal: Add devm version of thermal_zone_of_sensor_register Laxman Dewangan <ldewangan@nvidia.com> - 2016-03-09 13:30 +0100

csiph-web