Re: [PATCH] pinctrl: pxa2xx: export symbols

Path	csiph.com!weretis.net!feeder4.news.weretis.net!news.mixmin.net!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod
From	Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] pinctrl: pxa2xx: export symbols
Date	Wed, 09 Mar 2016 09:40:02 +0100
Message-ID	<raHOW-5is-11@gated-at.bofh.it> (permalink)
References	<raBTb-1fG-7@gated-at.bofh.it>
MIME-Version	1.0
Content-Type	text/plain; charset=iso-8859-1
Content-Disposition	inline
Content-Transfer-Encoding	8bit
User-Agent	Mutt/1.5.23 (2014-03-12)
X-Sa-Exim-Connect-IP	2001:67c:670:100:1d::c0
X-Sa-Exim-Mail-From	ukl@pengutronix.de
X-Sa-Exim-Scanned	No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false
X-Ptx-Original-Recipient	linux-kernel@vger.kernel.org
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	24
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org
X-Original-Date	Wed, 9 Mar 2016 09:31:21 +0100
X-Original-Message-ID	<20160309083121.GS8136@pengutronix.de>
X-Original-References	<1457489509-5680-1-git-send-email-linus.walleij@linaro.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1353901

Show key headers only | View raw

On Wed, Mar 09, 2016 at 09:11:49AM +0700, Linus Walleij wrote:
> The pxa2xxx fails some automated builds because of unexported
> symbols.
> 
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

There is 3a5242e648a8d009f0e0fd47867592e5265374b6 in linus/master which
does a part of this patch already.

Apart from that I don't understand the patch. The only user of
pxa2xx_pinctrl_init is drivers/pinctrl/pxa/pinctrl-pxa27x.c[1] and this
is built into the same module as pinctrl-pxa2xx.o. So without testing I
wonder in which configuration this fails to build.

Best regards
Uwe

[1] git grep -E pxa2xx_pinctrl_\(in\|ex\)it next/master
    git grep -E pxa2xx_pinctrl_\(in\|ex\)it linus/master

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] pinctrl: pxa2xx: export symbols Linus Walleij <linus.walleij@linaro.org> - 2016-03-09 03:20 +0100
  Re: [PATCH] pinctrl: pxa2xx: export symbols Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2016-03-09 09:40 +0100

csiph-web