Re: [PATCH 01/14] pinctrl: at91: use __maybe_unused to hide pm functions

From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 01/14] pinctrl: at91: use __maybe_unused to hide pm functions
Date	2016-03-09 05:10 +0100
Message-ID	<raDBD-2tF-11@gated-at.bofh.it> (permalink)
References	<r8hvz-1yT-3@gated-at.bofh.it> <r8hvB-1yT-33@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Mar 2, 2016 at 10:58 PM, Arnd Bergmann <arnd@arndb.de> wrote:

> The at91-pio4 pinctrl driver uses SET_SYSTEM_SLEEP_PM_OPS() to
> conditionally set the correct suspend/resume options, but they
> become unused when CONFIG_PM is disabled:
>
> drivers/pinctrl/pinctrl-at91-pio4.c:827:12: error: 'atmel_pctrl_suspend' defined but not used [-Werror=unused-function]
> drivers/pinctrl/pinctrl-at91-pio4.c:847:12: error: 'atmel_pctrl_resume' defined but not used [-Werror=unused-function]
>
> This adds __maybe_unused annotations so the compiler knows
> it can silently drop them instead of warning.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Patch applied with the maintainer ACKs.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 01/14] pinctrl: at91: use __maybe_unused to hide pm functions Linus Walleij <linus.walleij@linaro.org> - 2016-03-09 05:10 +0100

csiph-web