Re: [PATCH] EDAC, sb_edac: Fixed logic error in sb_edac driver

From	Aristeu Rozanski <aris@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] EDAC, sb_edac: Fixed logic error in sb_edac driver
Date	2016-03-07 17:30 +0100
Message-ID	<ra6cG-5dM-7@gated-at.bofh.it> (permalink)
References	<ra4ue-42s-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Mar 07, 2016 at 03:30:45PM +0100, Hubert Chrzaniuk wrote:
> Patch corrects a typo introduced previously.
> As a result under some configurations dimms were not
> correctly recognized. Problem affects only Xeon Phi architecture.
> 
> Signed-off-by: Hubert Chrzaniuk <hubert.chrzaniuk@intel.com>
> ---
>  drivers/edac/sb_edac.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/edac/sb_edac.c b/drivers/edac/sb_edac.c
> index e438ee5..f5c6b97 100644
> --- a/drivers/edac/sb_edac.c
> +++ b/drivers/edac/sb_edac.c
> @@ -1574,7 +1574,7 @@ static int knl_get_dimm_capacity(struct sbridge_pvt *pvt, u64 *mc_sizes)
>  				for (cha = 0; cha < KNL_MAX_CHAS; cha++) {
>  					if (knl_get_mc_route(target,
>  						mc_route_reg[cha]) == channel
> -						&& participants[channel]) {
> +						&& !participants[channel]) {
>  						participant_count++;
>  						participants[channel] = 1;
>  						break;

I can confirm this fixes the issues I've seen with the upstream driver.

Acked-by: Aristeu Rozanski <aris@redhat.com>

-- 
Aristeu

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] EDAC, sb_edac: Fixed logic error in sb_edac driver Hubert Chrzaniuk <hubert.chrzaniuk@intel.com> - 2016-03-07 15:40 +0100
  Re: [PATCH] EDAC, sb_edac: Fixed logic error in sb_edac driver Borislav Petkov <bp@alien8.de> - 2016-03-07 16:30 +0100
    RE: [PATCH] EDAC, sb_edac: Fixed logic error in sb_edac driver "Chrzaniuk, Hubert" <hubert.chrzaniuk@intel.com> - 2016-03-08 10:20 +0100
      Re: [PATCH] EDAC, sb_edac: Fixed logic error in sb_edac driver Borislav Petkov <bp@alien8.de> - 2016-03-08 11:30 +0100
  Re: [PATCH] EDAC, sb_edac: Fixed logic error in sb_edac driver Aristeu Rozanski <aris@redhat.com> - 2016-03-07 17:30 +0100

csiph-web