RE: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature

From	"Zhang, Rui" <rui.zhang@intel.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature
Date	2016-03-07 13:30 +0100
Message-ID	<ra2sr-2NF-41@gated-at.bofh.it> (permalink)
References	(1 earlier) <r89HI-4v3-3@gated-at.bofh.it> <r8p05-7eU-5@gated-at.bofh.it> <r9YIa-oh-23@gated-at.bofh.it> <r9Zbc-yj-13@gated-at.bofh.it> <r9Zux-U4-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Oh, BTW, you need to CC linux-pm@vger.kernel.org as well, so that we can see your patch via patchwork.

Please resend patch V2 to linux-pm@vger.kernel.org.

Thanks,
rui

> -----Original Message-----
> From: Wei Ni [mailto:wni@nvidia.com]
> Sent: Monday, March 07, 2016 5:16 PM
> To: Zhang, Rui <rui.zhang@intel.com>; thierry.reding@gmail.com;
> mikko.perttunen@kapsi.fi; Eduardo Valentin <edubezval@gmail.com>
> Cc: Matt Longnecker <mlongnecker@nvidia.com>; swarren@wwwdotorg.org;
> linux-tegra@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature
> Importance: High
> 
> 
> 
> On 2016年03月07日 16:55, Zhang, Rui wrote:
> > For the soc thermal driver changes, you'd better cc Eduardo at the same
> time so that he can include this in his soc-thermal pull request.
> > Surely I can queue this for 4.6 if Eduardo miss this.
> 
> Thanks for your help.
> 
> BTW, please add:
> Reviewed-by: Matt Longnecker <mlongnecker@nvidia.com>
> 
> Or I need to send v2 patch to add it?
> 
> Thanks.
> Wei.
> 
> >
> > Thanks,
> > rui
> >
> >> -----Original Message-----
> >> From: Wei Ni [mailto:wni@nvidia.com]
> >> Sent: Monday, March 07, 2016 4:26 PM
> >> To: thierry.reding@gmail.com; Zhang, Rui <rui.zhang@intel.com>;
> >> mikko.perttunen@kapsi.fi
> >> Cc: Matt Longnecker <mlongnecker@nvidia.com>;
> swarren@wwwdotorg.org;
> >> linux-tegra@vger.kernel.org; linux-kernel@vger.kernel.org
> >> Subject: Re: [PATCH] thermal: tegra_soctherm: fix sign bit of
> >> temperature
> >> Importance: High
> >>
> >> Hi, Rui and Thierry
> >> Could you please take a look at this patch?
> >>
> >> Thanks.
> >> Wei.
> >>
> >> On 2016年03月03日 08:08, Matt Longnecker wrote:
> >>>
> >>>
> >>> On 03/01/2016 11:40 PM, Wei Ni wrote:
> >>>>> diff --git a/drivers/thermal/tegra_soctherm.c
> >> b/drivers/thermal/tegra_soctherm.c
> >>>>> index 74ea5765938b..136975220c92 100644
> >>>>> --- a/drivers/thermal/tegra_soctherm.c
> >>>>> +++ b/drivers/thermal/tegra_soctherm.c
> >>>>> @@ -57,7 +57,7 @@
> >>>>>  #define READBACK_VALUE_MASK            0xff00
> >>>>>  #define READBACK_VALUE_SHIFT            8
> >>>>>  #define READBACK_ADD_HALF            BIT(7)
> >>>>> -#define READBACK_NEGATE                BIT(1)
> >>>>> +#define READBACK_NEGATE                BIT(0)
> >>> I confirm that this change is technically correct. It fixes a bug.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature Wei Ni <wni@nvidia.com> - 2016-03-07 09:30 +0100
  RE: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature "Zhang, Rui" <rui.zhang@intel.com> - 2016-03-07 10:00 +0100
    Re: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature Wei Ni <wni@nvidia.com> - 2016-03-07 10:20 +0100
      RE: [PATCH] thermal: tegra_soctherm: fix sign bit of temperature "Zhang, Rui" <rui.zhang@intel.com> - 2016-03-07 13:30 +0100

csiph-web