[PATCH] md/bitmap: remove redundant check

Path	csiph.com!au2pb.net!feeder.erje.net!2.us.feeder.erje.net!news2.arglkargh.de!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Eric Engestrom <eric.engestrom@imgtec.com>
Newsgroups	linux.kernel
Subject	[PATCH] md/bitmap: remove redundant check
Date	Mon, 07 Mar 2016 13:10:02 +0100
Message-ID	<ra294-2Fp-11@gated-at.bofh.it> (permalink)
X-Mailer	git-send-email 2.7.1
MIME-Version	1.0
Content-Type	text/plain
X-Originating-IP	[10.60.4.28]
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	24
Organization	linux.* mail to news gateway
X-Original-Cc	Eric Engestrom <eric.engestrom@imgtec.com>
X-Original-Date	Mon, 7 Mar 2016 12:01:05 +0000
X-Original-Message-ID	<1457352065-28994-1-git-send-email-eric.engestrom@imgtec.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1351562

Show key headers only | View raw

daemon_sleep is an unsigned, so testing if it's 0 or less than 1 does
the same thing.

Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
---
 drivers/md/bitmap.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/md/bitmap.c b/drivers/md/bitmap.c
index d80cce4..bbe7b64 100644
--- a/drivers/md/bitmap.c
+++ b/drivers/md/bitmap.c
@@ -510,8 +510,7 @@ static int bitmap_new_disk_sb(struct bitmap *bitmap)
 	sb->chunksize = cpu_to_le32(chunksize);
 
 	daemon_sleep = bitmap->mddev->bitmap_info.daemon_sleep;
-	if (!daemon_sleep ||
-	    (daemon_sleep < 1) || (daemon_sleep > MAX_SCHEDULE_TIMEOUT)) {
+	if (!daemon_sleep || (daemon_sleep > MAX_SCHEDULE_TIMEOUT)) {
 		printk(KERN_INFO "Choosing daemon_sleep default (5 sec)\n");
 		daemon_sleep = 5 * HZ;
 	}
-- 
2.7.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] md/bitmap: remove redundant check Eric Engestrom <eric.engestrom@imgtec.com> - 2016-03-07 13:10 +0100
  Re: [PATCH] md/bitmap: remove redundant check Shaohua Li <shli@kernel.org> - 2016-03-07 18:30 +0100

csiph-web