Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1451378

Re: [PATCH] dell-wmi: Add events created by Dell Rugged 2-in-1s

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wednesday 27 July 2016 17:55:09 Mario_Limonciello@dell.com wrote:
> > Hi! I'm not sure if KEY_PROG1/2/3 are good names here as we already
> > use
> >
> >those for other actions (see bios_to_linux_keycode). Also there is:
> I had missed this, do you have some recommendations on what would be
> better codes to map this to?

Problem is that I do not know when those KEY_PROG keys from 
bios_to_linux_keycode table are emitted. There are missing comments or 
description.

Are you able to find out description for all those keys in that table? 
Maybe now (when linux key constants are extended), there could be better 
candidates...

> I'll double check what the things that "were" mapping to KEY_PROG1
> etc actually were.  This might be a case of an expected clash if the
> functions aren't in current generations.
> 
> >/* Wifi Catcher */
> >
> > { KE_KEY,    0xe011, { KEY_PROG2 } },
> 
> It's worth mentioning that Wifi Catcher hasn't been used for any Dell
> laptops for a handful generations.  The rugged 2in1's are current
> generation that have these programmable buttons and don't have wifi
> catcher.

Anyway, what is "Wifi Catcher"? HW switch buttton which enable/disable 
wifi? Or something else?

> So there should be no "real" clash here.

Problem can be in future. This driver is unified for all Dell products 
with wmi interface and so future product could do some nasty things...

> > But probably we do not have better names...
> 
> In this particular case, I was thinking PROG1/2/3 were really the
> best option and would be most intuitive because the keys really are
> labels "P1" "P2" and "P3".

Probably yes, as I wrote I do not have in my mind better names for now.

> Here's the front of the tablet:
> http://shop-media.intel.com/api/v2/helperservice/getimage?url=http://
> images.icecat.biz/img/norm/high/30031725-706.jpg&height=550&width=550
> 
> > Another small cosmetic change: align WMI codes, so 0x157 and 0x850
> > are at some column (similar like are formatted other actions).
> 
> OK.

-- 
Pali Rohár
pali.rohar@gmail.com

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] dell-wmi: Add events created by Dell Rugged 2-in-1s Darren Hart <dvhart@infradead.org> - 2016-07-27 07:20 +0200
  Re: [PATCH] dell-wmi: Add events created by Dell Rugged 2-in-1s Pali Rohár <pali.rohar@gmail.com> - 2016-07-27 09:30 +0200
    Re: [PATCH] dell-wmi: Add events created by Dell Rugged 2-in-1s <Mario_Limonciello@Dell.com> - 2016-07-27 18:00 +0200
      Re: [PATCH] dell-wmi: Add events created by Dell Rugged 2-in-1s Pali Rohár <pali.rohar@gmail.com> - 2016-07-27 18:10 +0200
        Re: [PATCH] dell-wmi: Add events created by Dell Rugged 2-in-1s Darren Hart <dvhart@infradead.org> - 2016-07-27 18:40 +0200
        RE: [PATCH] dell-wmi: Add events created by Dell Rugged 2-in-1s <Mario_Limonciello@Dell.com> - 2016-07-27 21:10 +0200
          Re: [PATCH] dell-wmi: Add events created by Dell Rugged 2-in-1s Pali Rohár <pali.rohar@gmail.com> - 2016-07-27 22:20 +0200
            Re: [PATCH] dell-wmi: Add events created by Dell Rugged 2-in-1s Darren Hart <dvhart@infradead.org> - 2016-07-28 00:50 +0200
              Re: [PATCH] dell-wmi: Add events created by Dell Rugged 2-in-1s Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-07-28 01:10 +0200
                RE: [PATCH] dell-wmi: Add events created by Dell Rugged 2-in-1s <Mario_Limonciello@Dell.com> - 2016-07-28 18:00 +0200
                Re: [PATCH] dell-wmi: Add events created by Dell Rugged 2-in-1s Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-07-28 20:50 +0200
                Re: [PATCH] dell-wmi: Add events created by Dell Rugged 2-in-1s Pali Rohár <pali.rohar@gmail.com> - 2016-07-28 21:30 +0200
                RE: [PATCH] dell-wmi: Add events created by Dell Rugged 2-in-1s <Mario_Limonciello@Dell.com> - 2016-08-02 00:50 +0200
            RE: [PATCH] dell-wmi: Add events created by Dell Rugged 2-in-1s <Mario_Limonciello@Dell.com> - 2016-07-28 17:40 +0200

csiph-web