[PATCH 4/6] driver core: Don't leak secondary fwnode on device removal

From	Lukas Wunner <lukas@wunner.de>
Newsgroups	linux.kernel
Subject	[PATCH 4/6] driver core: Don't leak secondary fwnode on device removal
Date	2016-07-27 13:30 +0200
Message-ID	<rZvce-7cz-37@gated-at.bofh.it> (permalink)
References	<rZvcd-7cz-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

If device_add_property_set() is called for a device, a secondary fwnode
is allocated and assigned to the device but currently not freed once the
device is removed.

This can be triggered on Apple Macs if a Thunderbolt device is plugged
in on boot since Apple's NHI EFI driver sets a number of properties for
that device which are leaked on unplug.

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Andreas Noever <andreas.noever@gmail.com>
Signed-off-by: Lukas Wunner <lukas@wunner.de>
---
 drivers/base/core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/base/core.c b/drivers/base/core.c
index 0a8bdad..70c5be5 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -1266,6 +1266,7 @@ void device_del(struct device *dev)
 	bus_remove_device(dev);
 	device_pm_remove(dev);
 	driver_deferred_probe_del(dev);
+	device_remove_properties(dev);

 	/* Notify the platform of the removal, in case they
 	 * need to do anything...
-- 
2.8.1

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 4/6] driver core: Don't leak secondary fwnode on device  removal Lukas Wunner <lukas@wunner.de> - 2016-07-27 13:30 +0200

csiph-web