Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1451226
| From | Roger Pau Monné <roger.pau@citrix.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3] xen-blkfront: dynamic configuration of per-vbd resources |
| Date | 2016-07-27 13:10 +0200 |
| Message-ID | <rZuSS-75g-13@gated-at.bofh.it> (permalink) |
| References | <rZnHH-2rc-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, Jul 27, 2016 at 11:21:25AM +0800, Bob Liu wrote:
[...]
> +static ssize_t dynamic_reconfig_device(struct blkfront_info *info, ssize_t count)
> +{
> + /*
> + * Prevent new requests even to software request queue.
> + */
> + blk_mq_freeze_queue(info->rq);
> +
> + /*
> + * Guarantee no uncompleted reqs.
> + */
I'm also wondering, why do you need to guarantee that there are no
uncompleted requests? The resume procedure is going to call blkif_recover
that will take care of requeuing any unfinished requests that are on the
ring.
> + if (part_in_flight(&info->gd->part0) || info->reconfiguring) {
> + blk_mq_unfreeze_queue(info->rq);
> + pr_err("Dev:%s busy, please retry later.\n", dev_name(&info->xbdev->dev));
> + return -EBUSY;
> + }
Roger.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3] xen-blkfront: dynamic configuration of per-vbd resources Bob Liu <bob.liu@oracle.com> - 2016-07-27 05:30 +0200
Re: [PATCH v3] xen-blkfront: dynamic configuration of per-vbd resources Roger Pau Monné <roger.pau@citrix.com> - 2016-07-27 10:10 +0200
Re: [PATCH v3] xen-blkfront: dynamic configuration of per-vbd resources Bob Liu <bob.liu@oracle.com> - 2016-07-27 11:20 +0200
RE: [Xen-devel] [PATCH v3] xen-blkfront: dynamic configuration of per-vbd resources Paul Durrant <Paul.Durrant@citrix.com> - 2016-07-27 11:30 +0200
Re: [PATCH v3] xen-blkfront: dynamic configuration of per-vbd resources Roger Pau Monné <roger.pau@citrix.com> - 2016-07-27 12:10 +0200
Re: [PATCH v3] xen-blkfront: dynamic configuration of per-vbd resources Roger Pau Monné <roger.pau@citrix.com> - 2016-07-27 13:10 +0200
Re: [PATCH v3] xen-blkfront: dynamic configuration of per-vbd resources Bob Liu <bob.liu@oracle.com> - 2016-07-27 13:30 +0200
Re: [PATCH v3] xen-blkfront: dynamic configuration of per-vbd resources Roger Pau Monné <roger.pau@citrix.com> - 2016-07-27 16:30 +0200
Re: [PATCH v3] xen-blkfront: dynamic configuration of per-vbd resources Bob Liu <bob.liu@oracle.com> - 2016-07-28 01:10 +0200
Re: [PATCH v3] xen-blkfront: dynamic configuration of per-vbd resources Roger Pau Monné <roger.pau@citrix.com> - 2016-07-28 09:50 +0200
Re: [Xen-devel] [PATCH v3] xen-blkfront: dynamic configuration of per-vbd resources David Vrabel <david.vrabel@citrix.com> - 2016-07-28 11:40 +0200
csiph-web