Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1451151
| From | Bhaktipriya Shridhar <bhaktipriya96@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [RFC] usb: host: u132-hcd: Remove deprecated create_singlethread_workqueue |
| Date | 2016-07-27 11:30 +0200 |
| Message-ID | <rZtk6-5Wg-27@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
alloc_ordered_workqueue replaces the deprecated
create_singlethread_workqueue.
The workqueue "workqueue" has multiple workitems which may require
ordering. Hence, a dedicated ordered workqueue has been used.
Since the workqueue is not being used on a memory reclaim path,
WQ_MEM_RECLAIM has not been set.
Can the workitems run concurrently? Is the ordering among work items
necessary?
Thanks.
Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
drivers/usb/host/u132-hcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/u132-hcd.c b/drivers/usb/host/u132-hcd.c
index 43d5293..cbde189 100644
--- a/drivers/usb/host/u132-hcd.c
+++ b/drivers/usb/host/u132-hcd.c
@@ -3206,7 +3206,7 @@ static int __init u132_hcd_init(void)
if (usb_disabled())
return -ENODEV;
printk(KERN_INFO "driver %s\n", hcd_name);
- workqueue = create_singlethread_workqueue("u132");
+ workqueue = alloc_ordered_workqueue("u132", 0);
retval = platform_driver_register(&u132_platform_driver);
return retval;
}
--
2.1.4
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[RFC] usb: host: u132-hcd: Remove deprecated create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-07-27 11:30 +0200
Re: [RFC] usb: host: u132-hcd: Remove deprecated create_singlethread_workqueue Oliver Neukum <oneukum@suse.com> - 2016-07-27 11:40 +0200
Re: [RFC] usb: host: u132-hcd: Remove deprecated create_singlethread_workqueue Tejun Heo <tj@kernel.org> - 2016-07-27 20:10 +0200
Re: [RFC] usb: host: u132-hcd: Remove deprecated create_singlethread_workqueue Alan Stern <stern@rowland.harvard.edu> - 2016-07-27 21:00 +0200
Re: [RFC] usb: host: u132-hcd: Remove deprecated create_singlethread_workqueue Tejun Heo <tj@kernel.org> - 2016-07-27 21:30 +0200
Re: [RFC] usb: host: u132-hcd: Remove deprecated create_singlethread_workqueue Alan Stern <stern@rowland.harvard.edu> - 2016-07-27 22:50 +0200
Re: [RFC] usb: host: u132-hcd: Remove deprecated create_singlethread_workqueue Tejun Heo <tj@kernel.org> - 2016-07-29 15:20 +0200
Re: [RFC] usb: host: u132-hcd: Remove deprecated create_singlethread_workqueue Michal Hocko <mhocko@kernel.org> - 2016-08-01 16:00 +0200
Re: [RFC] usb: host: u132-hcd: Remove deprecated create_singlethread_workqueue Tejun Heo <tj@kernel.org> - 2016-08-01 16:30 +0200
Re: [RFC] usb: host: u132-hcd: Remove deprecated create_singlethread_workqueue Alan Stern <stern@rowland.harvard.edu> - 2016-08-01 21:10 +0200
Re: [RFC] usb: host: u132-hcd: Remove deprecated create_singlethread_workqueue Michal Hocko <mhocko@kernel.org> - 2016-08-01 21:40 +0200
Re: [RFC] usb: host: u132-hcd: Remove deprecated create_singlethread_workqueue Oliver Neukum <oneukum@suse.com> - 2016-08-02 10:20 +0200
Re: [RFC] usb: host: u132-hcd: Remove deprecated create_singlethread_workqueue Michal Hocko <mhocko@kernel.org> - 2016-08-02 10:40 +0200
Re: [RFC] usb: host: u132-hcd: Remove deprecated create_singlethread_workqueue Oliver Neukum <oneukum@suse.com> - 2016-08-02 12:10 +0200
Re: [RFC] usb: host: u132-hcd: Remove deprecated create_singlethread_workqueue Michal Hocko <mhocko@kernel.org> - 2016-08-02 14:00 +0200
Re: [RFC] usb: host: u132-hcd: Remove deprecated create_singlethread_workqueue Oliver Neukum <oneukum@suse.com> - 2016-08-02 15:40 +0200
Re: [RFC] usb: host: u132-hcd: Remove deprecated create_singlethread_workqueue Tejun Heo <tj@kernel.org> - 2016-08-02 21:20 +0200
Re: [RFC] usb: host: u132-hcd: Remove deprecated create_singlethread_workqueue Michal Hocko <mhocko@kernel.org> - 2016-08-02 23:40 +0200
Re: [RFC] usb: host: u132-hcd: Remove deprecated create_singlethread_workqueue Michal Hocko <mhocko@kernel.org> - 2016-08-02 16:00 +0200
Re: [RFC] usb: host: u132-hcd: Remove deprecated create_singlethread_workqueue Oliver Neukum <oneukum@suse.com> - 2016-08-02 19:20 +0200
csiph-web