Re: [PATCH] x86/fpu/xstate: Return error if xfeature bit is unset in XSAVES compacted-format buffer

From	Ingo Molnar <mingo@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] x86/fpu/xstate: Return error if xfeature bit is unset in XSAVES compacted-format buffer
Date	2016-07-27 11:10 +0200
Message-ID	<rZt0J-5Pc-23@gated-at.bofh.it> (permalink)
References	<rYVis-18i-91@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

* Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com> wrote:

> From: Sai Praneeth <sai.praneeth.prakhya@intel.com>
> 
> Currently, XSAVES compacted-format buffer will always contain space for
> all enabled states. If XSAVES compacted-format buffer is in use and
> an xstate component (E.g: PKRU xstate) is not present in the buffer
> (i.e. xcomp_bv does not have xfeature (E.g: XFEATURE_MASK_PKRU) bit
> set), then fpu__xfeature_set_state() returns error.

Please fix the changelog to conform to the standard changelog style:

 - first describe the symptoms of the bug - how does a user notice? 

 - then describe how the code behaves today and how that is causing the bug

 - and then only describe how it's fixed.

Thanks,

        Ingo

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] x86/fpu/xstate: Return error if xfeature bit is unset in  XSAVES compacted-format buffer Ingo Molnar <mingo@kernel.org> - 2016-07-27 11:10 +0200

csiph-web