Re: [PATCH 4/9] clk: sunxi-ng: mux: Add support for mux tables

From	Chen-Yu Tsai <wens@csie.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/9] clk: sunxi-ng: mux: Add support for mux tables
Date	2016-07-27 09:40 +0200
Message-ID	<rZrBE-4PS-23@gated-at.bofh.it> (permalink)
References	<rZ4F3-7pO-5@gated-at.bofh.it> <rZ4F3-7pO-13@gated-at.bofh.it> <rZeEp-52r-23@gated-at.bofh.it> <rZqYW-4mE-5@gated-at.bofh.it> <rZrih-4IM-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jul 27, 2016 at 3:18 PM, Jean-Francois Moine <moinejf@free.fr> wrote:
> On Wed, 27 Jul 2016 08:59:34 +0200
> Maxime Ripard <maxime.ripard@free-electrons.com> wrote:
>
>> On Tue, Jul 26, 2016 at 07:43:06PM +0200, Jean-Francois Moine wrote:
>> > On Tue, 26 Jul 2016 15:04:26 +0800
>> > Chen-Yu Tsai <wens@csie.org> wrote:
>> >
>> > > Some clock muxes have holes, i.e. invalid or unconnected inputs,
>> > > between parent mux values.
>> > >
>> > > Add support for specifying a mux table to map clock parents to
>> > > mux values.
>> >
>> > Putting empty strings in the holes should work. No?
>> > Ex:
>> >
>> > static const char * const csi_mclk_parents[] =
>> >     { "pll-video0", "pll-video1", "", "", "", "osc24M" };
>>
>> Not really. The clock would be declared as orphan, while it's really
>> not.
>>
>> Parenting functions would also not work as expected,
>> clk_hw_get_parent_by_index being the obvious example, in that case
>> returning the empty string for an invalid parent, while it should
>> really return NULL.
>
> I don't see why the clock should be orphan.
> Then, when a parent is "", clk_hw_get_parent_by_index() returns NULL.

There's no requirement for parent clk indexes to match the actual
register value, is there?

ChenYu

Thread

[PATCH 4/9] clk: sunxi-ng: mux: Add support for mux tables Chen-Yu Tsai <wens@csie.org> - 2016-07-26 09:10 +0200
  Re: [PATCH 4/9] clk: sunxi-ng: mux: Add support for mux tables Jean-Francois Moine <moinejf@free.fr> - 2016-07-26 19:50 +0200
    Re: [PATCH 4/9] clk: sunxi-ng: mux: Add support for mux tables Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-07-27 09:00 +0200
      Re: [PATCH 4/9] clk: sunxi-ng: mux: Add support for mux tables Jean-Francois Moine <moinejf@free.fr> - 2016-07-27 09:20 +0200
        Re: [PATCH 4/9] clk: sunxi-ng: mux: Add support for mux tables Chen-Yu Tsai <wens@csie.org> - 2016-07-27 09:40 +0200
        Re: [PATCH 4/9] clk: sunxi-ng: mux: Add support for mux tables Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-07-27 09:50 +0200
          Re: [PATCH 4/9] clk: sunxi-ng: mux: Add support for mux tables Jean-Francois Moine <moinejf@free.fr> - 2016-07-27 10:40 +0200
            Re: [PATCH 4/9] clk: sunxi-ng: mux: Add support for mux tables Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-07-28 15:30 +0200
              Re: [PATCH 4/9] clk: sunxi-ng: mux: Add support for mux tables Jean-Francois Moine <moinejf@free.fr> - 2016-07-28 16:30 +0200
  Re: [PATCH 4/9] clk: sunxi-ng: mux: Add support for mux tables Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-07-27 08:50 +0200

csiph-web