Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1451029

Re: [PATCH 2/6] extcon: Add the support for extcon property according to extcon type

From Guenter Roeck <groeck@google.com>
Newsgroups linux.kernel
Subject Re: [PATCH 2/6] extcon: Add the support for extcon property according to extcon type
Date 2016-07-27 06:00 +0200
Message-ID <rZoaJ-2AM-5@gated-at.bofh.it> (permalink)
References (4 earlier) <rZlFU-16J-9@gated-at.bofh.it> <rZm8V-1gn-1@gated-at.bofh.it> <rZo14-2xs-11@gated-at.bofh.it> <rZmBX-1Ls-7@gated-at.bofh.it> <rZo14-2xs-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, Jul 26, 2016 at 8:42 PM, Chanwoo Choi <cw00.choi@samsung.com> wrote:
> Hi Chris,
>
> On 2016년 07월 27일 11:09, Chris Zhong wrote:
>> Hi Guernter
>>
>> On 07/27/2016 09:44 AM, Guenter Roeck wrote:
>>> Hi Chris,
>>>
>>> On Tue, Jul 26, 2016 at 6:15 PM, Chris Zhong <zyw@rock-chips.com> wrote:
>>>
>>> [ ... ]
>>>
>>>>>      > +
>>>>>      > +/* Properties of EXTCON_TYPE_DISP. */
>>>>>      > +#define EXTCON_PROP_DISP_MIN           150
>>>>>      > +#define EXTCON_PROP_DISP_MAX           150
>>>>>      > +#define EXTCON_PROP_DISP_CNT   (EXTCON_PROP_DISP_MAX -
>>>>>      EXTCON_PROP_DISP_MIN)
>>>>>
>>>>>                   + 1
>>>>>
>>>>>
>>>>> ok.
>>>>
>>>> Tested with these "+1", it works for my DP patch.
>>>>
>>> You should be able to use
>>> https://chromium-review.googlesource.com/#/c/363623/1 as baseline (if
>>> you didn't do that already).
>>>
>>> Thanks,
>>> Guenter
>>
>> Thanks Guenter, and I saw this bug has fixed in extcon-test branch.
>>
>>
>
> Do you test it with extcon_set_property_capability()?
> And if you test this patch-es, could you send the tested-by tag for these patches?
>

For my part I did. Above link is public, so you should be able to see
the complete patch set which uses the new API from
drivers/extcon/extcon-cros_ec.c.

I'll re-test tomorrow with the updated patches from your test branch.

> I'll send the next version after a few days.

Great.

Thanks,
Guenter

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 2/6] extcon: Add the support for extcon property according to  extcon type Chanwoo Choi <cw00.choi@samsung.com> - 2016-07-26 14:20 +0200
  Re: [PATCH 2/6] extcon: Add the support for extcon property according  to extcon type Guenter Roeck <groeck@google.com> - 2016-07-27 00:10 +0200
    Re: [PATCH 2/6] extcon: Add the support for extcon property according  to extcon type Chris Zhong <zyw@rock-chips.com> - 2016-07-27 03:20 +0200
      Re: [PATCH 2/6] extcon: Add the support for extcon property according  to extcon type Guenter Roeck <groeck@google.com> - 2016-07-27 03:50 +0200
        Re: [PATCH 2/6] extcon: Add the support for extcon property according  to extcon type Chris Zhong <zyw@rock-chips.com> - 2016-07-27 04:20 +0200
          Re: [PATCH 2/6] extcon: Add the support for extcon property according  to extcon type Chanwoo Choi <cw00.choi@samsung.com> - 2016-07-27 05:50 +0200
            Re: [PATCH 2/6] extcon: Add the support for extcon property according  to extcon type Chanwoo Choi <cw00.choi@samsung.com> - 2016-07-27 06:00 +0200
              Re: [PATCH 2/6] extcon: Add the support for extcon property according  to extcon type Chris Zhong <zyw@rock-chips.com> - 2016-07-27 06:40 +0200
            Re: [PATCH 2/6] extcon: Add the support for extcon property according  to extcon type Guenter Roeck <groeck@google.com> - 2016-07-27 06:00 +0200
  Re: [PATCH 2/6] extcon: Add the support for extcon property according  to extcon type Guenter Roeck <groeck@google.com> - 2016-07-27 19:30 +0200
    Re: [PATCH 2/6] extcon: Add the support for extcon property according  to extcon type Chanwoo Choi <cw00.choi@samsung.com> - 2016-07-29 09:10 +0200

csiph-web