Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1451036

RE: [PATCH 1/6] extcon: Add the extcon_type to group each connector into five category

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

> This patch adds the new extcon type to group the each connecotr
> into following five category. This type would be used to handle
> the connectors as a group unit instead of a connector unit.
> - EXTCON_TYPE_USB  : USB connector
> - EXTCON_TYPE_CHG  : Charger connector
> - EXTCON_TYPE_JACK : Jack connector

"Jack" seems to be an internal jargon that many people won't recognize.
It's, in fact, 3.5-pi, isn't it?

Anyway, this is already being used as an enum with drivers,
I'd suggest to add a comment in extcon.h stating that 
"Jack connector" is usually the 3.5-pi earbud connector.

Anyway, I like the direction of this patch.


Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>

Cheers,
MyungJoo

> --- a/include/linux/extcon.h
> +++ b/include/linux/extcon.h
> @@ -29,6 +29,15 @@
>  #include <linux/device.h>
>  
>  /*
> + * Define the type of supported external connectors
> + */
> +#define EXTCON_TYPE_USB		BIT(0)	/* USB connector */
> +#define EXTCON_TYPE_CHG		BIT(1)	/* Charger connector */
> +#define EXTCON_TYPE_JACK	BIT(2)	/* Jack connector */
+                                /* Usually, this is a 3.5-pi earbud conector */
> +#define EXTCON_TYPE_DISP	BIT(3)	/* Display connector */
> +#define EXTCON_TYPE_MISC	BIT(4)	/* Miscellaneous connector */
> +
> +/*
>   * Define the unique id of supported external connectors
>   */
>  #define EXTCON_NONE		0
> -- 
> 1.9.1
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/6] extcon: Add the support for extcon type and property Chanwoo Choi <cw00.choi@samsung.com> - 2016-07-26 14:20 +0200
  [PATCH 4/6] extcon: Rename the extcon_set/get_state() to maintain the  function naming pattern Chanwoo Choi <cw00.choi@samsung.com> - 2016-07-26 14:20 +0200
  [PATCH 5/6] extcon: Add the synchronization extcon APIs to support the  notification Chanwoo Choi <cw00.choi@samsung.com> - 2016-07-26 14:20 +0200
    Re: [PATCH 5/6] extcon: Add the synchronization extcon APIs to  support the notification Chris Zhong <zyw@rock-chips.com> - 2016-07-27 09:40 +0200
      Re: [PATCH 5/6] extcon: Add the synchronization extcon APIs to support  the notification Chanwoo Choi <cw00.choi@samsung.com> - 2016-07-27 09:50 +0200
  [PATCH 1/6] extcon: Add the extcon_type to group each connector into  five category Chanwoo Choi <cw00.choi@samsung.com> - 2016-07-26 14:20 +0200
  [PATCH 3/6] extcon: Add the support for the capability of each property Chanwoo Choi <cw00.choi@samsung.com> - 2016-07-26 14:20 +0200
  [PATCH 6/6] extcon: Add EXTCON_DISP_DP and the property for USB Type-C Chanwoo Choi <cw00.choi@samsung.com> - 2016-07-26 14:20 +0200
  RE: [PATCH 1/6] extcon: Add the extcon_type to group each connector into five category MyungJoo Ham <myungjoo.ham@samsung.com> - 2016-07-27 06:30 +0200
    Re: [PATCH 1/6] extcon: Add the extcon_type to group each connector  into five category Chanwoo Choi <cw00.choi@samsung.com> - 2016-07-27 07:40 +0200

csiph-web