[PATCH] tools: iio: iio_generic_buffer: initialize channel array pointer

From	Alison Schofield <amsfield22@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH] tools: iio: iio_generic_buffer: initialize channel array pointer
Date	2016-07-27 05:20 +0200
Message-ID	<rZny1-2o5-1@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Uninitialized channel pointer causes segmentation fault when we
call free(channel) during cleanup() with no channels initialized.
This happens when you exit early for usage errors.  Initialize
the pointer to NULL when it is declared.

Signed-off-by: Alison Schofield <amsfield22@gmail.com>
Cc: Daniel Baluta <daniel.baluta@gmail.com>
---
 tools/iio/iio_generic_buffer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/iio/iio_generic_buffer.c b/tools/iio/iio_generic_buffer.c
index 0e8a1f7..ae68bf0 100644
--- a/tools/iio/iio_generic_buffer.c
+++ b/tools/iio/iio_generic_buffer.c
@@ -348,7 +348,7 @@ int main(int argc, char **argv)
 	int notrigger = 0;
 	char *dummy;
 
-	struct iio_channel_info *channels;
+	struct iio_channel_info *channels = NULL;
 
 	register_cleanup();
 
-- 
2.1.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] tools: iio: iio_generic_buffer: initialize channel array  pointer Alison Schofield <amsfield22@gmail.com> - 2016-07-27 05:20 +0200
  Re: [PATCH] tools: iio: iio_generic_buffer: initialize channel array  pointer Gregor Boirie <gregor.boirie@parrot.com> - 2016-07-27 10:20 +0200

csiph-web