Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1451019
| From | Salah Triki <salah.triki@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [RESEND PATCH 3/4] fs: befs: Remove useless calls to brelse in befs_find_brun_dblindirect |
| Date | 2016-07-27 05:20 +0200 |
| Message-ID | <rZny1-2o5-11@gated-at.bofh.it> (permalink) |
| References | <rZny1-2o5-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
The calls to brelse are useless since dbl_indir_block and indir_block are NULL. Signed-off-by: Salah Triki <salah.triki@gmail.com> Acked-by: Luis de Bethencourt <luisbg@osg.samsung.com> --- fs/befs/datastream.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/befs/datastream.c b/fs/befs/datastream.c index e224b9a..b68b6f9 100644 --- a/fs/befs/datastream.c +++ b/fs/befs/datastream.c @@ -471,7 +471,6 @@ befs_find_brun_dblindirect(struct super_block *sb, (unsigned long) iaddr2blockno(sb, &data->double_indirect) + dbl_which_block); - brelse(dbl_indir_block); return BEFS_ERR; } @@ -496,7 +495,6 @@ befs_find_brun_dblindirect(struct super_block *sb, befs_error(sb, "%s couldn't read the indirect block " "at blockno %lu", __func__, (unsigned long) iaddr2blockno(sb, &indir_run) + which_block); - brelse(indir_block); return BEFS_ERR; } -- 1.9.1
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[RESEND PATCH 1/4] fs: befs: Remove redundant validation from befs_find_brun_direct Salah Triki <salah.triki@gmail.com> - 2016-07-27 05:20 +0200
[RESEND PATCH 3/4] fs: befs: Remove useless calls to brelse in befs_find_brun_dblindirect Salah Triki <salah.triki@gmail.com> - 2016-07-27 05:20 +0200
[RESEND PATCH 4/4] fs: befs: Remove goto from befs_bread_iaddr Salah Triki <salah.triki@gmail.com> - 2016-07-27 05:20 +0200
Re: [RESEND PATCH 4/4] fs: befs: Remove goto from befs_bread_iaddr Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-07-27 17:40 +0200
Re: [RESEND PATCH 1/4] fs: befs: Remove redundant validation from befs_find_brun_direct Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-07-27 17:30 +0200
csiph-web