Re: [PATCH] ide: hpt366: fix incorrect mask when checking at cmd_high_time

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ide: hpt366: fix incorrect mask when checking at cmd_high_time
Date	2016-07-27 00:30 +0200
Message-ID	<rZj1o-7PB-23@gated-at.bofh.it> (permalink)
References	<rU3JE-44Q-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Colin King <colin.king@canonical.com>
Date: Tue, 12 Jul 2016 11:59:39 +0100

> From: Colin Ian King <colin.king@canonical.com>
> 
> According to the HPT366 data sheet, PCI config space dword 0x40-0x43
> bits 11:8 specify the primary drive cmd_high_time, however,
> currently just 3 bits of the 4 are being used because the mask
> is 0x07 and not 0x0f.  Fix the mask, allowing for the 40MHz clock
> to be detected.
> 
> Also add in missing space between switch and parenthesis to clean
> up a checkpatch warning.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Applied.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] ide: hpt366: fix incorrect mask when checking at  cmd_high_time David Miller <davem@davemloft.net> - 2016-07-27 00:30 +0200

csiph-web