Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1450925

Re: [PATCH] ASoC: dapm: Add a dummy snd_pcm_runtime to avoid NULL pointer access

Show all headers | View raw

On Tue, Jul 26, 2016 at 12:28:40PM -0700, Nicolin Chen wrote:
> diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
> index 8698c26..eed15ca 100644
> --- a/sound/soc/soc-dapm.c
> +++ b/sound/soc/soc-dapm.c
> @@ -3493,6 +3493,7 @@ static int snd_soc_dai_link_event(struct snd_soc_dapm_widget *w,
>  	const struct snd_soc_pcm_stream *config = w->params + w->params_select;
>  	struct snd_pcm_substream substream;
>  	struct snd_pcm_hw_params *params = NULL;
> +	struct snd_pcm_runtime runtime;

Got a warning from test robot:

sound/soc/soc-dapm.c: In function 'snd_soc_dai_link_event':
sound/soc/soc-dapm.c:3614:1: warning: the frame size of 1304 bytes is larger
					than 1024 bytes [-Wframe-larger-than=]

Kzalloc() might be a better solution here.

Will send a v2. So please ignore this one.

Thanks
Nicolin

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ASoC: dapm: Add a dummy snd_pcm_runtime to avoid NULL pointer access Nicolin Chen <nicoleotsuka@gmail.com> - 2016-07-26 21:30 +0200
  Re: [PATCH] ASoC: dapm: Add a dummy snd_pcm_runtime to avoid NULL  pointer access Nicolin Chen <nicoleotsuka@gmail.com> - 2016-07-26 23:30 +0200

csiph-web